You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/07/07 14:02:35 UTC
[GitHub] flink pull request #4283: [FLINK-7132] [java] Fix BulkIteration parallelism
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4283
[FLINK-7132] [java] Fix BulkIteration parallelism
Copy the parallelism when translating a BulkIteration.
`translateBulkIteration` now mirrors the setup of the following function `translateDeltaIteration`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 7132_fix_bulkiteration_parallelism
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4283
----
commit c4d3d48eb5467630d7f731f1dfa4c9733b2093ab
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-07-07T13:17:33Z
[FLINK-7132] [java] Fix BulkIteration parallelism
Copy the parallelism when translating a BulkIteration.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4283: [FLINK-7132] [java] Fix BulkIteration parallelism
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4283: [FLINK-7132] [java] Fix BulkIteration parallelism
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4283
Perfect, thanks.
+1 to merge this for `master` and `release-1.3`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4283: [FLINK-7132] [java] Fix BulkIteration parallelism
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4283
Okay, thanks @StephanEwen. I've added a simple starter `BulkIterationTranslationTest` based on your `DeltaIterationTranslationTest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4283: [FLINK-7132] [java] Fix BulkIteration parallelism
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4283
Looks good, thanks!
Any way this can be guarded by an additional check in one of the existing tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---