[jira] [Resolved] (OPENNLP-1264) Trivial fixes to enable building on, gasp, Windows

["Jeff Zemerick (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OPENNLP-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Zemerick resolved OPENNLP-1264.
------------------------------------
    Fix Version/s:     (was: 1.9.2)
       Resolution: Won't Fix

I believe these issues have since been resolved for building on Windows. This branch fails the 4 BRAT tests mentioned in OPENNLP-1358 (built from the current master), so it seems the issues targeted in this pull request have been addressed.

I am going to close the [pull request|https://github.com/apache/opennlp/pull/353] and task but please feel free to reopen the task/PR if needed.

> Trivial fixes to enable building on, gasp, Windows
> --------------------------------------------------
>
>                 Key: OPENNLP-1264
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1264
>             Project: OpenNLP
>          Issue Type: Task
>            Reporter: Tim Allison
>            Assignee: Tim Allison
>            Priority: Trivial
>
> I had to change 3 things to get a clean build on Windows...I'm not sure the solutions are the most elegant, and these may be user error
> 1) I had to turn off (fail on error) in style checking because of a problem w new lines. On nearly every file, I got this failure.
> {noformat}
> [ERROR] src\test\java\opennlp\tools\util\VersionTest.java:[0] (misc) NewlineAtEndOfFile: File does not end with a newline.
> [WARNING] checkstyle:check violations detected but failOnViolation set to false
> {noformat}
> 2) {{LanguageDetectorEvaluatorTest#processSample}} fails because '\n' are expected, but Windows, of course, writes '\r\n' with {{println}}
> 3) I intentionally have a space in the directory structure to my IdeaProjects directory, which can cause problems on Windows when finding paths.  There are two areas where this happens.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)