You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/18 01:37:15 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #21042: Use calcite jdbc ordinal to replace ShardingSphere column metadata in SQLFederationResultSetMetaData
strongduanmu opened a new pull request, #21042:
URL: https://github.com/apache/shardingsphere/pull/21042
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21042: Use calcite jdbc ordinal to replace ShardingSphere column metadata in SQLFederationResultSetMetaData
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21042:
URL: https://github.com/apache/shardingsphere/pull/21042#issuecomment-1250177792
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21042?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21042](https://codecov.io/gh/apache/shardingsphere/pull/21042?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (387232c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a20b8d246f3ff97ac62657abf89ce656298bf1cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a20b8d2) will **decrease** coverage by `0.62%`.
> The diff coverage is `41.66%`.
```diff
@@ Coverage Diff @@
## master #21042 +/- ##
============================================
- Coverage 61.60% 60.97% -0.63%
+ Complexity 2470 2468 -2
============================================
Files 4056 4056
Lines 55763 55761 -2
Branches 9452 9451 -1
============================================
- Hits 34351 34002 -349
- Misses 18540 18919 +379
+ Partials 2872 2840 -32
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ration/advanced/AdvancedSQLFederationExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL0FkdmFuY2VkU1FMRmVkZXJhdGlvbkV4ZWN1dG9yLmphdmE=) | `20.00% <0.00%> (-1.96%)` | :arrow_down: |
| [...nced/resultset/SQLFederationResultSetMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9TUUxGZWRlcmF0aW9uUmVzdWx0U2V0TWV0YURhdGEuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lfederation/optimizer/ShardingSphereOptimizer.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvU2hhcmRpbmdTcGhlcmVPcHRpbWl6ZXIuamF2YQ==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...ion/advanced/resultset/SQLFederationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9TUUxGZWRlcmF0aW9uUmVzdWx0U2V0LmphdmE=) | `81.81% <100.00%> (ø)` | |
| [...izer/metadata/translatable/TranslatableSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvbWV0YWRhdGEvdHJhbnNsYXRhYmxlL1RyYW5zbGF0YWJsZVNjaGVtYS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../metadata/translatable/TranslatableFilterRule.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvbWV0YWRhdGEvdHJhbnNsYXRhYmxlL1RyYW5zbGF0YWJsZUZpbHRlclJ1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...metadata/translatable/TranslatableProjectRule.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvbWV0YWRhdGEvdHJhbnNsYXRhYmxlL1RyYW5zbGF0YWJsZVByb2plY3RSdWxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...erter/segment/expression/impl/ColumnConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvY29udmVydGVyL3NlZ21lbnQvZXhwcmVzc2lvbi9pbXBsL0NvbHVtbkNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ta/translatable/TranslatableProjectFilterRule.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvbWV0YWRhdGEvdHJhbnNsYXRhYmxlL1RyYW5zbGF0YWJsZVByb2plY3RGaWx0ZXJSdWxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ssion/impl/BinaryOperationExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvY29udmVydGVyL3NlZ21lbnQvZXhwcmVzc2lvbi9pbXBsL0JpbmFyeU9wZXJhdGlvbkV4cHJlc3Npb25Db252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (-97.06%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/shardingsphere/pull/21042/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #21042: Use calcite jdbc ordinal to replace ShardingSphere column metadata in SQLFederationResultSetMetaData
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21042:
URL: https://github.com/apache/shardingsphere/pull/21042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org