You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by td...@apache.org on 2016/10/11 17:53:08 UTC
spark git commit: [SPARK-17346][SQL][TESTS] Fix the flaky topic
deletion in KafkaSourceStressSuite
Repository: spark
Updated Branches:
refs/heads/master c8c090640 -> 75b9e3514
[SPARK-17346][SQL][TESTS] Fix the flaky topic deletion in KafkaSourceStressSuite
## What changes were proposed in this pull request?
A follow up Pr for SPARK-17346 to fix flaky `org.apache.spark.sql.kafka010.KafkaSourceStressSuite`.
Test log: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.4/1855/testReport/junit/org.apache.spark.sql.kafka010/KafkaSourceStressSuite/_It_is_not_a_test_/
Looks like deleting the Kafka internal topic `__consumer_offsets` is flaky. This PR just simply ignores internal topics.
## How was this patch tested?
Existing tests.
Author: Shixiong Zhu <sh...@databricks.com>
Closes #15384 from zsxwing/SPARK-17346-flaky-test.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/75b9e351
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/75b9e351
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/75b9e351
Branch: refs/heads/master
Commit: 75b9e351413dca0930e8545e6283874db09d8482
Parents: c8c0906
Author: Shixiong Zhu <sh...@databricks.com>
Authored: Tue Oct 11 10:53:07 2016 -0700
Committer: Tathagata Das <ta...@gmail.com>
Committed: Tue Oct 11 10:53:07 2016 -0700
----------------------------------------------------------------------
.../org/apache/spark/sql/kafka010/KafkaSourceSuite.scala | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/75b9e351/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
----------------------------------------------------------------------
diff --git a/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala b/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
index 6c03070..c640b93 100644
--- a/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
+++ b/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
@@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicInteger
import scala.util.Random
import org.apache.kafka.clients.producer.RecordMetadata
-import org.scalatest.BeforeAndAfter
import org.scalatest.time.SpanSugar._
import org.apache.spark.sql.execution.streaming._
@@ -344,7 +343,7 @@ class KafkaSourceSuite extends KafkaSourceTest {
}
-class KafkaSourceStressSuite extends KafkaSourceTest with BeforeAndAfter {
+class KafkaSourceStressSuite extends KafkaSourceTest {
import testImplicits._
@@ -358,12 +357,6 @@ class KafkaSourceStressSuite extends KafkaSourceTest with BeforeAndAfter {
start + Random.nextInt(start + end - 1)
}
- after {
- for (topic <- testUtils.getAllTopicsAndPartitionSize().toMap.keys) {
- testUtils.deleteTopic(topic)
- }
- }
-
test("stress test with multiple topics and partitions") {
topics.foreach { topic =>
testUtils.createTopic(topic, partitions = nextInt(1, 6))
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org