You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2010/04/16 01:56:49 UTC

[jira] Created: (HADOOP-6710) Symbolic umask for file creation is not consistent with linux

Symbolic umask for file creation is not consistent with linux
-------------------------------------------------------------

                 Key: HADOOP-6710
                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Suresh Srinivas


Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860402#action_12860402 ] 

Hadoop QA commented on HADOOP-6710:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12441987/hadoop-6710.patch
  against trunk revision 937183.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/475/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/475/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/475/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/475/console

This message is automatically generated.

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>         Attachments: hadoop-6710.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated HADOOP-6710:
--------------------------------

    Hadoop Flags: [Reviewed]

+1. Looks excellent.

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>         Attachments: hadoop-6710.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-6710:
------------------------------------

        Status: Resolved  (was: Patch Available)
      Assignee: Suresh Srinivas
    Resolution: Fixed

Committed the patch.

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: hadoop-6710.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-6710:
------------------------------------

    Attachment: hadoop-6710.patch

Attached patch:
# Adds support for posix compliant symbolic umask support with extensive tests
# Current symbolic umask of format "u=,g=,o=" is not parsed correctly. This should be same as octal umask 777. Changing the regex to support this.

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>         Attachments: hadoop-6710.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-6710:
------------------------------------

    Status: Patch Available  (was: Open)

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>         Attachments: hadoop-6710.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6710) Symbolic umask for file creation is not consistent with linux

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857600#action_12857600 ] 

Suresh Srinivas commented on HADOOP-6710:
-----------------------------------------

Snippet from the posix specification http://www.opengroup.org/onlinepubs/000095399/utilities/umask.html:
For a symbolic_mode value, the new value of the file mode creation mask shall be the logical complement of the file permission bits portion of the file mode specified by the symbolic_mode  string.

In a symbolic_mode value, the permissions op characters '+' and '-' shall be interpreted relative to the current file mode creation mask; '+' shall cause the bits for the indicated permissions to be cleared in the mask; '-' shall cause the bits for the indicated permissions to be set in the mask.

The interpretation of mode values that specify file mode bits other than the file permission bits is unspecified.

In the octal integer form of mode, the specified bits are set in the file mode creation mask.

The file mode creation mask shall be set to the resulting numeric value.

> Symbolic umask for file creation is not consistent with linux
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-6710:
------------------------------------

    Attachment: hadoop-6710.rel20.patch

20 version of the patch.

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: hadoop-6710.patch, hadoop-6710.rel20.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-6710:
------------------------------------

              Summary: Symbolic umask for file creation is not consistent with posix  (was: Symbolic umask for file creation is not consistent with linux)
    Affects Version/s: 0.21.0
                       0.22.0

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-6710) Symbolic umask for file creation is not consistent with posix

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862333#action_12862333 ] 

Jakob Homan commented on HADOOP-6710:
-------------------------------------

+1 on 20 version.

> Symbolic umask for file creation is not consistent with posix
> -------------------------------------------------------------
>
>                 Key: HADOOP-6710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6710
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: hadoop-6710.patch, hadoop-6710.rel20.patch
>
>
> Currently both octal and symbolic umask are used to reset the file creation mode bits. This is not consistent with the behavior defined in posix. Making it consistent would avoid confusion to the HDFS users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.