You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/10/21 17:20:58 UTC
[GitHub] leventov commented on issue #6490: Fix various bugs;
Enable more IntelliJ inspections and update error-prone
leventov commented on issue #6490: Fix various bugs; Enable more IntelliJ inspections and update error-prone
URL: https://github.com/apache/incubator-druid/pull/6490#issuecomment-431686909
@b-slim there are three "real" bugs fixed in this PR, other changes are dead code removals mostly:
1) https://github.com/apache/incubator-druid/pull/6490/files#diff-03e48730fe9116ce0c8c99610d4e37f0L183: could lead to NPE in runtime, ternary operator + primitives + null = bad!
2) https://github.com/apache/incubator-druid/pull/6490/files#diff-03e48730fe9116ce0c8c99610d4e37f0L221, same as the previous one
3) https://github.com/apache/incubator-druid/pull/6490/files#diff-e212e5107b0e6b3bb4112d2d097c78a1R815: a property is not copied in a copy constructor
I didn't add new tests, such bugs should be now catched, well, by the newly added inspections and error-prone rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org