[GitHub] [incubator-nuttx] cederom commented on a change in pull request #4673: CeDeROM add *BSD support 20211016

[GitBox <gi...@apache.org>]

cederom commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735645169



##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
 
 WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
 TOPDIR="${WD}/.."
+MAKE_CMD="make"
 USAGE="
 
-USAGE: ${0} [-E] [-e] [-l|m|c|g|n] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
+USAGE: ${0} [-E] [-e] [-l|m|c|g|n|B] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]

Review comment:
       Thank you @xiaoxiang781216 for your review :-) As explained in the commit message `-b` switch is already taken by `configure.c` program. In order to maintain coherence between all those configuration tools I chose `-B` for BSD family :-)
   
   I also would prefer `-b` switch but then we would have to change also the `configure.c` part that would probably break backward compatibility..?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org