[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637668#comment-15637668 ] 

ASF GitHub Bot commented on KAFKA-4322:
---------------------------------------

GitHub user markcshelton opened a pull request:

    https://github.com/apache/kafka/pull/2105

    KAFKA-4322 StateRestoreCallback begin and end indication

    This adds a begin and end callback to StateRestoreCallback.
    
    The contribution is my original work and I license the work to Apache Kafka under the Kafka's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markcshelton/kafka KAFKA-4322

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2105
    
----
commit 9f59ea6ff2aac94bdd84eaafda36c860b12e1dcd
Author: Mark Shelton <ma...@gmx.us>
Date:   2016-11-04T20:57:37Z

    changes KAFKA-4322 StateRestoreCallback begin and end indication

----


> StateRestoreCallback begin and end indication
> ---------------------------------------------
>
>                 Key: KAFKA-4322
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4322
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 0.10.0.1
>            Reporter: Mark Shelton
>            Assignee: Guozhang Wang
>            Priority: Minor
>
> In Kafka Streams, the StateRestoreCallback interface provides only a single method "restore(byte[] key, byte[] value)" that is called for every key-value pair to be restored. 
> It would be nice to have "beginRestore" and "endRestore" methods as part of StateRestoreCallback.
> Kafka Streams would call "beginRestore" before restoring any keys, and would call "endRestore" when it determines that it is done. This allows an implementation, for example, to report on the number of keys restored and perform a commit after the last key was restored. Other uses are conceivable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)