You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 11:52:15 UTC
[GitHub] [arrow-rs] Ted-Jiang opened a new issue, #2171: No need construct def_level_decoder and rep_level_decoder in each page.
Ted-Jiang opened a new issue, #2171:
URL: https://github.com/apache/arrow-rs/issues/2171
https://github.com/apache/arrow-rs/blob/37dd03756953d92bd303549fb0f7610a6d3c5c56/parquet/src/arrow/record_reader/mod.rs#L97-L120
`def_level_decoder` and `rep_level_decoder` are base one the the `column_desc` (column chunk level). No need to create them in each page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2171: No need construct def_level_decoder and rep_level_decoder in each page.
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2171:
URL: https://github.com/apache/arrow-rs/issues/2171#issuecomment-1256022353
Can this be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on issue #2171: No need construct def_level_decoder and rep_level_decoder in each page.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on issue #2171:
URL: https://github.com/apache/arrow-rs/issues/2171#issuecomment-1195383861
@tustvold we can create it when new ColChunk, am i right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2171: No need construct def_level_decoder and rep_level_decoder in each page.
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2171:
URL: https://github.com/apache/arrow-rs/issues/2171#issuecomment-1195387842
Theoretically, in practice I wouldn't expect it to make a difference. The columns chunks should be large enough that any overhead will be amortised to insignificance...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2171: No need construct def_level_decoder and rep_level_decoder in each page.
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #2171: No need construct def_level_decoder and rep_level_decoder in each page.
URL: https://github.com/apache/arrow-rs/issues/2171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on issue #2171: No need construct def_level_decoder and rep_level_decoder in each page.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on issue #2171:
URL: https://github.com/apache/arrow-rs/issues/2171#issuecomment-1257213314
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org