You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/08 07:05:52 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

sureshanaparti commented on a change in pull request #4386:
URL: https://github.com/apache/cloudstack/pull/4386#discussion_r501492064



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
##########
@@ -194,7 +194,7 @@ def _redundant_on(self):
         heartbeat_cron.commit()
 
         proc = CsProcess(['/usr/sbin/keepalived'])

Review comment:
       @ustcweizhou specifying "/usr/sbin/keepalived" here may not be required as grep is used instead.
   
   I understand this issue is with _keepalived_ process, but on a broader view, other processes might have similar issue later, can this be fixed in _CsProcess.py find()_ ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org