You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2018/03/29 21:20:01 UTC
[1/2] wicket git commit: EnclosureContainer - added missing
super.onConfigure() call
Repository: wicket
Updated Branches:
refs/heads/master 65227fb14 -> 1d2c6d077
EnclosureContainer - added missing super.onConfigure() call
this closes #271
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0c200132
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0c200132
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0c200132
Branch: refs/heads/master
Commit: 0c200132f92dcc7ba073d84fcff5d23caa9e40b3
Parents: 65227fb
Author: Vít Rozkovec <vi...@gmail.com>
Authored: Thu Mar 29 20:01:56 2018 +0200
Committer: Sven Meier <sv...@apache.org>
Committed: Thu Mar 29 23:19:09 2018 +0200
----------------------------------------------------------------------
.../org/apache/wicket/markup/html/basic/EnclosureContainer.java | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/0c200132/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/EnclosureContainer.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/EnclosureContainer.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/EnclosureContainer.java
index 09845e1..48c9391 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/EnclosureContainer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/EnclosureContainer.java
@@ -77,6 +77,7 @@ public class EnclosureContainer extends WebMarkupContainer
@Override
protected void onConfigure()
{
+ super.onConfigure();
child.configure();
setVisible(child.determineVisibility());
[2/2] wicket git commit: WICKET-6543 add test for EnclosureContainer
Posted by sv...@apache.org.
WICKET-6543 add test for EnclosureContainer
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1d2c6d07
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1d2c6d07
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1d2c6d07
Branch: refs/heads/master
Commit: 1d2c6d0776b9b53a3dad56004be4fdef4f1cfa97
Parents: 0c20013
Author: Sven Meier <sv...@apache.org>
Authored: Thu Mar 29 23:17:04 2018 +0200
Committer: Sven Meier <sv...@apache.org>
Committed: Thu Mar 29 23:19:37 2018 +0200
----------------------------------------------------------------------
.../html/basic/EnclosureContainerPage.html | 19 +++++++++
.../html/basic/EnclosureContainerPage.java | 42 ++++++++++++++++++++
.../html/basic/EnclosureContainerTest.java | 22 ++++++++++
3 files changed, 83 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/1d2c6d07/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.html
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.html b/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.html
new file mode 100644
index 0000000..d62629a
--- /dev/null
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.html
@@ -0,0 +1,19 @@
+<!--
+ ====================================================================
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<html xmlns:wicket>
+<body>
+ <span wicket:id="container"><span wicket:id="label"></span></span>
+</body>
+</html>
http://git-wip-us.apache.org/repos/asf/wicket/blob/1d2c6d07/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.java
new file mode 100644
index 0000000..0b15f87
--- /dev/null
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerPage.java
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.markup.html.basic;
+
+import org.apache.wicket.markup.html.WebPage;
+
+/**
+ */
+public class EnclosureContainerPage extends WebPage
+{
+ private static final long serialVersionUID = 1L;
+
+ public EnclosureContainer container;
+
+ /**
+ * Construct.
+ */
+ public EnclosureContainerPage()
+ {
+ Label label = new Label("label");
+ label.setVisible(false);
+
+ container = new EnclosureContainer("container", label);
+ add(container);
+
+ container.add(label);
+ }
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/1d2c6d07/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerTest.java
new file mode 100644
index 0000000..0f73945
--- /dev/null
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/EnclosureContainerTest.java
@@ -0,0 +1,22 @@
+package org.apache.wicket.markup.html.basic;
+
+import org.apache.wicket.util.tester.WicketTestCase;
+import org.junit.Test;
+
+/**
+ * Test for {@link EnclosureContainer}.
+ *
+ * @author svenmeier
+ */
+public class EnclosureContainerTest extends WicketTestCase
+{
+
+ @Test
+ public void test() {
+ EnclosureContainerPage page = new EnclosureContainerPage();
+
+ tester.startPage(page);
+
+ assertFalse(page.container.isVisible());
+ }
+}