You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/05 22:48:12 UTC
Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1673
https://issues.apache.org/jira/browse/MESOS-1673
Repository: mesos-git
Description
-------
See summary and ticket.
Diffs
-----
src/slave/constants.hpp bc16fe5
src/slave/constants.cpp f00300d
src/slave/slave.cpp ef921e1
src/tests/slave_tests.cpp 432d8a2
Diff: https://reviews.apache.org/r/24339/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 5, 2014, 9:43 p.m., Ben Mahler wrote:
> > Ship It!
>
> Ben Mahler wrote:
> Same TODO in master's constants?
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49645
-----------------------------------------------------------
On Aug. 5, 2014, 9:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24339/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 9:33 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1673
> https://issues.apache.org/jira/browse/MESOS-1673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bc16fe5
> src/slave/constants.cpp f00300d
> src/slave/slave.cpp ef921e1
> src/tests/slave_tests.cpp 432d8a2
>
> Diff: https://reviews.apache.org/r/24339/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673.
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 5, 2014, 9:43 p.m., Ben Mahler wrote:
> > Ship It!
Same TODO in master's constants?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49645
-----------------------------------------------------------
On Aug. 5, 2014, 9:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24339/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 9:33 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1673
> https://issues.apache.org/jira/browse/MESOS-1673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bc16fe5
> src/slave/constants.cpp f00300d
> src/slave/slave.cpp ef921e1
> src/tests/slave_tests.cpp 432d8a2
>
> Diff: https://reviews.apache.org/r/24339/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49645
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Aug. 5, 2014, 9:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24339/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 9:33 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1673
> https://issues.apache.org/jira/browse/MESOS-1673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bc16fe5
> src/slave/constants.cpp f00300d
> src/slave/slave.cpp ef921e1
> src/tests/slave_tests.cpp 432d8a2
>
> Diff: https://reviews.apache.org/r/24339/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 9:33 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Used a function to return the constant.
Bugs: MESOS-1673
https://issues.apache.org/jira/browse/MESOS-1673
Repository: mesos-git
Description
-------
See summary and ticket.
Diffs (updated)
-----
src/slave/constants.hpp bc16fe5
src/slave/constants.cpp f00300d
src/slave/slave.cpp ef921e1
src/tests/slave_tests.cpp 432d8a2
Diff: https://reviews.apache.org/r/24339/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24339: Killed MASTER_PING_TIMEOUT for fixing MESOS-1673.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49638
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/24339/#comment86888>
it might be worth a method to calculate this so it isn't repeated everywhere.
Duration masterPingTimeout() {
return master::SLAVE_PING_TIMEOUT * master::MAX_SLAVE_PING_TIMEOUTS;
}
- Dominic Hamon
On Aug. 5, 2014, 1:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24339/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 1:48 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1673
> https://issues.apache.org/jira/browse/MESOS-1673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp bc16fe5
> src/slave/constants.cpp f00300d
> src/slave/slave.cpp ef921e1
> src/tests/slave_tests.cpp 432d8a2
>
> Diff: https://reviews.apache.org/r/24339/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>