[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7386: Updating contributing/install docs

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7386: Updating contributing/install docs
URL: https://github.com/apache/incubator-superset/pull/7386#discussion_r279587182
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -293,20 +293,58 @@ python setup.py build_sphinx
 
 ### Flask server
 
-Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps.
+#### OS Dependencies
+
+Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps. 
+
+In addition you will need to install the mysql client to get mysql_config, which is required by mysqlclient in requirements-dev.txt.
 
 Review comment:
   I don't think we should require mysql to be installed to do development. The solution here is probably to remove mysqlclient from `requirements-dev.txt` or use a different version that does not require have the underlying libs / mysql_config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org