You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Christophe Taton (JIRA)" <ji...@apache.org> on 2007/07/26 02:15:31 UTC
[jira] Created: (HADOOP-1653) FSDirectory class code cleanup
FSDirectory class code cleanup
------------------------------
Key: HADOOP-1653
URL: https://issues.apache.org/jira/browse/HADOOP-1653
Project: Hadoop
Issue Type: Improvement
Components: dfs
Affects Versions: 0.15.0
Reporter: Christophe Taton
Priority: Trivial
- lets FSDirectory.INode become a static class, thus sparing one pointer per INode
- removes an unused constructor for FSDirectory.INode
- merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1653:
-------------------------------------
Affects Version/s: 0.14.0
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.14.0, 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516070 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
+1
fsdirectory-cleanup-20070725-1706-bis.patch
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706-bis.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515821 ]
Christophe Taton commented on HADOOP-1653:
------------------------------------------
Ok, then I am fine with the initial change.
I just realize how insane changing the serialization format is!
+1 for fsdirectory-cleanup-20070725-1706.patch
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch, fsdirectory-cleanup-20070725-1939.patch, fsdirectory-cleanup-20070725-2005.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1653:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.15.0
0.14.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks Christophe.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.14.0, 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Fix For: 0.14.0, 0.15.0
>
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: fsdirectory-cleanup-20070725-1706.patch
Here is a patch (~160 lines).
All JUnit test pass.
Christophe T.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515474 ]
Christophe Taton commented on HADOOP-1653:
------------------------------------------
Ok, I replace UTF8 with Text.
Should I also remove its use in other log methods: logRename, logDelete and logSetReplication?
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: fsdirectory-cleanup-20070725-1706-bis.patch
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706-bis.patch, fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Status: Patch Available (was: Reopened)
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton reopened HADOOP-1653:
--------------------------------------
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515469 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
Codes look good. I like the ideas of making FSDirectory.INode static and using StringBuffer. It helps reducing memory usages.
Since you are editing FSEditLog, could you also remove the use of the deprecated UTF8 in logCreateFile and logMkDir?
Thanks.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton resolved HADOOP-1653.
--------------------------------------
Resolution: Fixed
Patch available
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515481 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
We should probably leave them there. Otherwise, the patch will be quite involved again.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515920 ]
Hadoop QA commented on HADOOP-1653:
-----------------------------------
-1, could not apply patch.
The patch command could not apply the latest attachment http://issues.apache.org/jira/secure/attachment/12362566/fsdirectory-cleanup-20070725-1706.patch as a patch to trunk revision r560014.
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/478/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: (was: fsdirectory-cleanup-20070725-1706-bis.patch)
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: (was: fsdirectory-cleanup-20070725-1939.patch)
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515900 ]
Hadoop QA commented on HADOOP-1653:
-----------------------------------
-1, could not apply patch.
The patch command could not apply the latest attachment http://issues.apache.org/jira/secure/attachment/12362566/fsdirectory-cleanup-20070725-1706.patch as a patch to trunk revision r560014.
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/477/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515470 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
Codes look good. I like the ideas of making FSDirectory.INode static and using StringBuffer. It helps reducing memory usages.
Since you are editing FSEditLog, could you also remove the use of the deprecated UTF8 in logCreateFile and logMkDir?
Thanks.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516496 ]
Hadoop QA commented on HADOOP-1653:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12362788/fsdirectory-cleanup-20070730-1111.patch applied and successfully tested against trunk revision r560014.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/483/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/483/console
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515806 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
+1 for fsdirectory-cleanup-20070725-1706.patch
Codes look good.
Chiristophe, the issue of changing UTF8 in FSEditLog is not that simple since some other part of the system will read the log file. If we only change here, then the reading part might not work. I am sorry for asking you to do so.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch, fsdirectory-cleanup-20070725-1939.patch, fsdirectory-cleanup-20070725-2005.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by Michael Stack <st...@duboce.net>.
From the 'Contributing your work' section of
http://wiki.apache.org/lucene-hadoop/HowToContribute:
"Should your patch earn a -1 on the Hudson test, set the issue status to
'Resume Progress', upload a patch with necessary fixes and then set the
status to 'Submit Patch' again."
Let us know if the cited section is unclear or needs improvement so it
can be fixed.
Yours,
St.Ack
Christophe Taton wrote:
> Ok, I remade my patch following the howto carefully. I removed the previous
> patch and attached a new one.
> I am a bit confused now, is it ok or should I cancel and submit again?
> Thanks.
>
> On 7/26/07, Nigel Daley <nd...@yahoo-inc.com> wrote:
>
>> You can find the process here:
>> http://wiki.apache.org/lucene-hadoop/HowToContribute
>>
>> Note that the automated patch process attempts to apply the latest
>> patch (the one that was uploaded last) and will ignore *.htm and
>> *.html files.
>>
>>
>> On Jul 26, 2007, at 3:55 PM, Christophe Taton (JIRA) wrote:
>>
>>
>>> [ https://issues.apache.org/jira/browse/HADOOP-1653?
>>> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>
>>> Christophe Taton updated HADOOP-1653:
>>> -------------------------------------
>>>
>>> Status: Patch Available (was: Reopened)
>>>
>>> Sorry, just trying to figure out how the issue workflow works...
>>>
>>>
>>>> FSDirectory class code cleanup
>>>> ------------------------------
>>>>
>>>> Key: HADOOP-1653
>>>> URL: https://issues.apache.org/jira/browse/
>>>> HADOOP-1653
>>>> Project: Hadoop
>>>> Issue Type: Improvement
>>>> Components: dfs
>>>> Affects Versions: 0.15.0
>>>> Reporter: Christophe Taton
>>>> Priority: Trivial
>>>> Attachments: fsdirectory-cleanup-20070725-1706.patch
>>>>
>>>>
>>>> - lets FSDirectory.INode become a static class, thus sparing one
>>>> pointer per INode
>>>> - removes an unused constructor for FSDirectory.INode
>>>> - merges identical methods INode.getAbsoluteName() and
>>>> INode.computeName() and optimizes it using StringBuffer
>>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
>
Re: [jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by Doug Cutting <cu...@apache.org>.
Christophe Taton wrote:
> Ok, I remade my patch following the howto carefully. I removed the previous
> patch and attached a new one.
> I am a bit confused now, is it ok or should I cancel and submit again?
Yes. A Hudson patch run is triggered each time a patch transitions to
"Patch Available", so to trigger another run you must cancel and
re-submit. Note that before you submit you should be certain that the
patch applies to an otherwise clean subversion checkout, and that unit
tests pass after it is applied.
Doug
Re: [jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by Christophe Taton <ta...@google.com>.
Ok, I remade my patch following the howto carefully. I removed the previous
patch and attached a new one.
I am a bit confused now, is it ok or should I cancel and submit again?
Thanks.
On 7/26/07, Nigel Daley <nd...@yahoo-inc.com> wrote:
>
> You can find the process here:
> http://wiki.apache.org/lucene-hadoop/HowToContribute
>
> Note that the automated patch process attempts to apply the latest
> patch (the one that was uploaded last) and will ignore *.htm and
> *.html files.
>
>
> On Jul 26, 2007, at 3:55 PM, Christophe Taton (JIRA) wrote:
>
> >
> > [ https://issues.apache.org/jira/browse/HADOOP-1653?
> > page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Christophe Taton updated HADOOP-1653:
> > -------------------------------------
> >
> > Status: Patch Available (was: Reopened)
> >
> > Sorry, just trying to figure out how the issue workflow works...
> >
> >> FSDirectory class code cleanup
> >> ------------------------------
> >>
> >> Key: HADOOP-1653
> >> URL: https://issues.apache.org/jira/browse/
> >> HADOOP-1653
> >> Project: Hadoop
> >> Issue Type: Improvement
> >> Components: dfs
> >> Affects Versions: 0.15.0
> >> Reporter: Christophe Taton
> >> Priority: Trivial
> >> Attachments: fsdirectory-cleanup-20070725-1706.patch
> >>
> >>
> >> - lets FSDirectory.INode become a static class, thus sparing one
> >> pointer per INode
> >> - removes an unused constructor for FSDirectory.INode
> >> - merges identical methods INode.getAbsoluteName() and
> >> INode.computeName() and optimizes it using StringBuffer
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
>
>
Re: [jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by Nigel Daley <nd...@yahoo-inc.com>.
You can find the process here:
http://wiki.apache.org/lucene-hadoop/HowToContribute
Note that the automated patch process attempts to apply the latest
patch (the one that was uploaded last) and will ignore *.htm and
*.html files.
On Jul 26, 2007, at 3:55 PM, Christophe Taton (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-1653?
> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Christophe Taton updated HADOOP-1653:
> -------------------------------------
>
> Status: Patch Available (was: Reopened)
>
> Sorry, just trying to figure out how the issue workflow works...
>
>> FSDirectory class code cleanup
>> ------------------------------
>>
>> Key: HADOOP-1653
>> URL: https://issues.apache.org/jira/browse/
>> HADOOP-1653
>> Project: Hadoop
>> Issue Type: Improvement
>> Components: dfs
>> Affects Versions: 0.15.0
>> Reporter: Christophe Taton
>> Priority: Trivial
>> Attachments: fsdirectory-cleanup-20070725-1706.patch
>>
>>
>> - lets FSDirectory.INode become a static class, thus sparing one
>> pointer per INode
>> - removes an unused constructor for FSDirectory.INode
>> - merges identical methods INode.getAbsoluteName() and
>> INode.computeName() and optimizes it using StringBuffer
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Status: Patch Available (was: Reopened)
Sorry, just trying to figure out how the issue workflow works...
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515862 ]
Hairong Kuang commented on HADOOP-1653:
---------------------------------------
Hi Christophe, could you delete two unwanted patches and then change this issue to be patch available? Otherwise, your patch can not be comitted. :-)
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch, fsdirectory-cleanup-20070725-1939.patch, fsdirectory-cleanup-20070725-2005.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515815 ]
Hairong Kuang commented on HADOOP-1653:
---------------------------------------
The reason that we should not replace UTF8 with Text in FSEditLog is that their serialized formats are different. The replacement changes the edit log's on-disk format, causing backward compatibility problem when upgrading dfs.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch, fsdirectory-cleanup-20070725-1939.patch, fsdirectory-cleanup-20070725-2005.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: fsdirectory-cleanup-20070730-1111.patch
Same patch, successfully tested tested against trunk.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton reopened HADOOP-1653:
--------------------------------------
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Status: In Progress (was: Patch Available)
Testing again.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706-bis.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: (was: fsdirectory-cleanup-20070725-1706.patch)
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706-bis.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: fsdirectory-cleanup-20070725-2005.patch
fsdirectory-cleanup-20070725-1939.patch
Here are 2 differents patches:
- fsdirectory-cleanup-20070725-1939.patch (~370 lines) removes all references to UTF8 in FSEditLog. I submit it also as I created and tested it before your answer;
- fsdirectory-cleanup-20070725-2005.patch (~250 lines) removes references to UTF8 in FSEditLog for the methods logCreateFile(), logMkDir() and update their symmetric in loadFSEdits().
Both pass all JUnit tests. Choose the one you prefer.
Christophe T.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch, fsdirectory-cleanup-20070725-1939.patch, fsdirectory-cleanup-20070725-2005.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515468 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
Codes look good. I like the ideas of making FSDirectory.INode static and using StringBuffer. It helps reducing memory usages.
Since you are editing FSEditLog, could you also remove the use of the deprecated UTF8 in logCreateFile and logMkDir?
Thanks.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-1653:
-------------------------------------------
Comment: was deleted
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515952 ]
Hadoop QA commented on HADOOP-1653:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362650/fsdirectory-cleanup-20070725-1706-bis.patch against trunk revision r560014.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/479/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/479/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706-bis.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton resolved HADOOP-1653.
--------------------------------------
Resolution: Fixed
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070730-1111.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1653) FSDirectory class code cleanup
Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Taton updated HADOOP-1653:
-------------------------------------
Attachment: (was: fsdirectory-cleanup-20070725-2005.patch)
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName() and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.