You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/05 22:49:24 UTC

[GitHub] [hbase] liuml07 commented on a change in pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

liuml07 commented on a change in pull request #2204:
URL: https://github.com/apache/hbase/pull/2204#discussion_r466046163



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java
##########
@@ -271,7 +270,20 @@ public void disableStatusJournal() {
 
   @Override
   public String prettyPrintJournal() {
-    return StringUtils.join("\n\t", getStatusJournal());
+    StringBuilder sb = new StringBuilder();
+    for (int i = 0; i < journal.size(); i++) {

Review comment:
       Will `journal` be null ever?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org