[jira] [Commented] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

["Rob Meng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127500#comment-17127500 ] 

Rob Meng commented on KAFKA-7833:
---------------------------------

I'm looking for my first issue to tackle. It sounds like adding a duplicated name check in StreamsBuilder build path should suffice. Can I take this one?

I'm thinking a node name conflict check at [https://github.com/apache/kafka/blob/43a9e39983bc3fc2363723b9c555e49b016c1ae2/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphNode.java#L79-L81]

 

Or would that be too restrictive, and the check should be implemented at InternalStreamsBuilder level?

> StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-7833
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7833
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 2.1.0
>            Reporter: Sam Lendle
>            Priority: Major
>              Labels: newbie
>
> {{StoreBuilder<KeyValueStore<String, String>> storeBuilder =}}
> {{ Stores.keyValueStoreBuilder(Stores.inMemoryKeyValueStore("global-store"), null, null);}}
> {{ builder.addGlobalStore(}}
> {{ storeBuilder,}}
> {{ "global-topic",}}
> {{ Consumed.with(null, null),}}
> {{ new KTableSource(storeBuilder.name())}}
> {{ );}}
> {{builder.addStateStore(storeBuilder); }}
> {{builder.build();}}
>  
>  
> Does not throw an exception.
>  
> cc [~mjsax]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)