You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/13 20:00:19 UTC
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/
-----------------------------------------------------------
(Updated May 13, 2014, 11 a.m.)
Review request for Aurora.
Changes
-------
changed groups.
Repository: aurora
Description
-------
Add support for custom project to list-missing-shipits.
Search for rbt on PATH.
Diffs
-----
build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
Diff: https://reviews.apache.org/r/21386/diff/
Testing
-------
Ran script against project Mesos.
Thanks,
Dominic Hamon
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
> On May 13, 2014, 11:07 a.m., Bill Farner wrote:
> > build-support/tools/list-missing-shipits, line 94
> > <https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94>
> >
> > At a quick glance, it's not obvious how this relates to plumbing the 'project' argument. Was there another issue you bumped into? Is this so you can use the script outside the repo?
yes - other projects don't have rbt in the specific path the script was pointing at.
I considered keeping this as the default if 'rbt' isn't found on the path but thought that might be flaky.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42853
-----------------------------------------------------------
On May 13, 2014, 11:07 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 11:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Kevin Sweeney <ke...@apache.org>.
> On May 13, 2014, 11:07 a.m., Bill Farner wrote:
> > build-support/tools/list-missing-shipits, line 94
> > <https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94>
> >
> > At a quick glance, it's not obvious how this relates to plumbing the 'project' argument. Was there another issue you bumped into? Is this so you can use the script outside the repo?
>
> Dominic Hamon wrote:
> yes - other projects don't have rbt in the specific path the script was pointing at.
>
> I considered keeping this as the default if 'rbt' isn't found on the path but thought that might be flaky.
FWIW I'd highly recommend the aurora approach (self-bootstrapping, isolated rbt) over requiring a global installation of it with pip, since you get to explicitly specify the target version and it's one less barrier to entry for new contributors. To get this in another repo you'd want to copy ./rbt, ./build-support/virtualenv, and ./build-support/tools/list-missing-shipits.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42853
-----------------------------------------------------------
On May 13, 2014, 11:07 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 11:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
> On May 13, 2014, 11:07 a.m., Bill Farner wrote:
> > build-support/tools/list-missing-shipits, line 94
> > <https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94>
> >
> > At a quick glance, it's not obvious how this relates to plumbing the 'project' argument. Was there another issue you bumped into? Is this so you can use the script outside the repo?
>
> Dominic Hamon wrote:
> yes - other projects don't have rbt in the specific path the script was pointing at.
>
> I considered keeping this as the default if 'rbt' isn't found on the path but thought that might be flaky.
>
> Kevin Sweeney wrote:
> FWIW I'd highly recommend the aurora approach (self-bootstrapping, isolated rbt) over requiring a global installation of it with pip, since you get to explicitly specify the target version and it's one less barrier to entry for new contributors. To get this in another repo you'd want to copy ./rbt, ./build-support/virtualenv, and ./build-support/tools/list-missing-shipits.
that sounds like a great plan, especially with all the recent churn on our own post-review script. Perhaps we should compare notes on each approach.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42853
-----------------------------------------------------------
On May 13, 2014, 11:07 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 11:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Jake Farrell <jf...@apache.org>.
> On May 13, 2014, 6:07 p.m., Bill Farner wrote:
> > build-support/tools/list-missing-shipits, line 94
> > <https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94>
> >
> > At a quick glance, it's not obvious how this relates to plumbing the 'project' argument. Was there another issue you bumped into? Is this so you can use the script outside the repo?
>
> Dominic Hamon wrote:
> yes - other projects don't have rbt in the specific path the script was pointing at.
>
> I considered keeping this as the default if 'rbt' isn't found on the path but thought that might be flaky.
>
> Kevin Sweeney wrote:
> FWIW I'd highly recommend the aurora approach (self-bootstrapping, isolated rbt) over requiring a global installation of it with pip, since you get to explicitly specify the target version and it's one less barrier to entry for new contributors. To get this in another repo you'd want to copy ./rbt, ./build-support/virtualenv, and ./build-support/tools/list-missing-shipits.
>
> Dominic Hamon wrote:
> that sounds like a great plan, especially with all the recent churn on our own post-review script. Perhaps we should compare notes on each approach.
Agree with Kevin on this, we should keep the set path for our version of rbt which runs within venv and bootstraps itself (this helps avoid issues like Mesos ran into with the latest version of rbt). It might be worth looking into as a sub command within rbt to avoid having to call externally
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42853
-----------------------------------------------------------
On May 13, 2014, 6:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 6:07 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42853
-----------------------------------------------------------
build-support/tools/list-missing-shipits
<https://reviews.apache.org/r/21386/#comment76767>
At a quick glance, it's not obvious how this relates to plumbing the 'project' argument. Was there another issue you bumped into? Is this so you can use the script outside the repo?
- Bill Farner
On May 13, 2014, 6:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 6:07 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42889
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 13, 2014, 9:18 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 9:18 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review45792
-----------------------------------------------------------
ping
- Dominic Hamon
On May 15, 2014, 10:28 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 10:28 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-428
> https://issues.apache.org/jira/browse/AURORA-428
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review43890
-----------------------------------------------------------
Kevin - can you take a look at this?
- Bill Farner
On May 15, 2014, 5:28 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 5:28 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-428
> https://issues.apache.org/jira/browse/AURORA-428
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review44554
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 15, 2014, 10:28 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 10:28 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-428
> https://issues.apache.org/jira/browse/AURORA-428
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/
-----------------------------------------------------------
(Updated June 16, 2014, 1:57 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-428
https://issues.apache.org/jira/browse/AURORA-428
Repository: aurora
Description (updated)
-------
Add support for custom project to list-missing-shipits.
Diffs
-----
build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
Diff: https://reviews.apache.org/r/21386/diff/
Testing
-------
Ran script against project Mesos.
Thanks,
Dominic Hamon
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/
-----------------------------------------------------------
(Updated May 15, 2014, 10:28 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
added issue reference - no functional change.
Bugs: AURORA-428
https://issues.apache.org/jira/browse/AURORA-428
Repository: aurora
Description
-------
Add support for custom project to list-missing-shipits.
Search for rbt on PATH.
Diffs
-----
build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
Diff: https://reviews.apache.org/r/21386/diff/
Testing
-------
Ran script against project Mesos.
Thanks,
Dominic Hamon
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review43080
-----------------------------------------------------------
please create a jira issue for this and then +1
- Jake Farrell
On May 13, 2014, 9:18 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 9:18 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
>
>
> Diffs
> -----
>
> build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
>
> Diff: https://reviews.apache.org/r/21386/diff/
>
>
> Testing
> -------
>
> Ran script against project Mesos.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/
-----------------------------------------------------------
(Updated May 13, 2014, 2:18 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
reverted change to rbt search path.
Repository: aurora
Description
-------
Add support for custom project to list-missing-shipits.
Search for rbt on PATH.
Diffs (updated)
-----
build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
Diff: https://reviews.apache.org/r/21386/diff/
Testing
-------
Ran script against project Mesos.
Thanks,
Dominic Hamon
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/
-----------------------------------------------------------
(Updated May 13, 2014, 6:07 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
-------
Add support for custom project to list-missing-shipits.
Search for rbt on PATH.
Diffs
-----
build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
Diff: https://reviews.apache.org/r/21386/diff/
Testing
-------
Ran script against project Mesos.
Thanks,
Dominic Hamon
Re: Review Request 21386: Add support for custom project to
list-missing-shipits
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/
-----------------------------------------------------------
(Updated May 13, 2014, 6:03 p.m.)
Review request for Aurora.
Changes
-------
s/mesos/Aurora/ for review group.
Repository: aurora
Description
-------
Add support for custom project to list-missing-shipits.
Search for rbt on PATH.
Diffs
-----
build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7
Diff: https://reviews.apache.org/r/21386/diff/
Testing
-------
Ran script against project Mesos.
Thanks,
Dominic Hamon