[GitHub] dangogh opened a new pull request #2711: add profile constraint cdn not null

[GitBox <gi...@apache.org>]

dangogh opened a new pull request #2711: add profile constraint cdn not null
URL: https://github.com/apache/trafficcontrol/pull/2711
 
 
   #### What does this PR do?
   Adds constraint to profile table to disallow null cdn.
   Only does this after ensuring that any null cdn currently in the db is set to the `ALL` cdn.
   
   Fixes #2710 
   
   #### Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _________
   
   #### What is the best way to verify this PR?
   From a previous version of TO, get a copy of the database.
   
   `psql ... traffic_ops -c '\d profile'` should not show `not null` in the description of the cdn column.    Run `db/admin.pl upgrade` and do the same psql command -- should now show `not null`.
   
   Run `db/admin.pl reset` to put the db back to initial state.  That column should show `not null`.
   
   #### Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [x] This PR includes all required license headers
   - [x] This PR does *NOT* fix a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services