[GitHub] [commons-collections] Claudenw commented on a diff in pull request #276: COLLECTIONS-803: prevent duplicate call to convertKey on put for CaseInsensitiveMap

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on code in PR #276:
URL: https://github.com/apache/commons-collections/pull/276#discussion_r1145997983


##########
src/test/java/org/apache/commons/collections4/map/CaseInsensitiveMapTest.java:
##########
@@ -147,4 +148,20 @@ public void testPutAll() {
             || !caseInsensitiveMap.containsValue("Three")); // ones collapsed
         assertEquals("Four", caseInsensitiveMap.get(null));
     }
+
+    // COLLECTIONS-803
+    @Test
+    @SuppressWarnings("unchecked")
+    public void testPutConvertKeyOnlyOnce() {
+        CaseInsensitiveMap mock = EasyMock.partialMockBuilder(CaseInsensitiveMap.class)

Review Comment:
   CaseInsensitiveMap is a raw type. References to generic type CaseInsensitiveMap<K,V> should be parameterized



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org