You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2008/12/30 19:09:44 UTC
[jira] Created: (LUCENE-1505) Remove NumberUtils from spatial
contrib
Remove NumberUtils from spatial contrib
---------------------------------------
Key: LUCENE-1505
URL: https://issues.apache.org/jira/browse/LUCENE-1505
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/spatial
Reporter: Ryan McKinley
Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1505) Change contrib/spatial to use trie's
NumericUtils, and remove NumberUtils
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1505:
---------------------------------------
Fix Version/s: 2.9
Summary: Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils (was: Remove NumberUtils from spatial contrib)
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Simon Willnauer
> Fix For: 2.9
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1505) Remove NumberUtils from spatial
contrib
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer reassigned LUCENE-1505:
---------------------------------------
Assignee: Simon Willnauer
> Remove NumberUtils from spatial contrib
> ---------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Simon Willnauer
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1505) Change contrib/spatial to use trie's
NumericUtils, and remove NumberUtils
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1505.
----------------------------------------
Resolution: Fixed
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1505) Remove NumberUtils from spatial
contrib
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720359#action_12720359 ]
Simon Willnauer commented on LUCENE-1505:
-----------------------------------------
This issue depends on LUCENE_1496 which is set to won't_fix. I guess I can close / resolve this too.
Any concers? Speak up please!
simon
> Remove NumberUtils from spatial contrib
> ---------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1505) Change contrib/spatial to use
trie's NumericUtils, and remove NumberUtils
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731993#action_12731993 ]
Michael McCandless commented on LUCENE-1505:
--------------------------------------------
bq. For completeness, shoudl we also add them for the ones with the shift value at the end? an char[]? I was reluctant to do this.
Let's hold off & add these when the need first arises?
bq. I wonder if it would make sense to do some cleanup in the code (final vars and args etc.) and if we should remove this logging code
Agreed -- looks like you've opened a new issue for this already; thanks!
I'll commit shortly.
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1505) Change contrib/spatial to use trie's
NumericUtils, and remove NumberUtils
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1505:
---------------------------------------
Attachment: LUCENE-1505.patch
Attached patch. I added utility methods to NumericUtil to do double/float -> string, and v/v, and then did a straight replacement everywhere NumberUtils was used, and removed NumberUtils.
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1505) Change contrib/spatial to use
trie's NumericUtils, and remove NumberUtils
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731636#action_12731636 ]
Uwe Schindler commented on LUCENE-1505:
---------------------------------------
Patch looks good. The best is, that you can now use the double FieldCache which should speed up the LocalLucene queries and needs less memory.
By the way: I was also tending to add these convenience methods to NumericUtils :-) For completeness, shoudl we also add them for the ones with the shift value at the end? an char[]? I was reluctant to do this.
I think the easy conversion methods to/from String withou shift would be enough.
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1505) Change contrib/spatial to use
trie's NumericUtils, and remove NumberUtils
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731635#action_12731635 ]
Simon Willnauer commented on LUCENE-1505:
-----------------------------------------
Hey Mike, thanks for taking this. I was too busy last week and I rather spent time on Lucene-1566.
I looked at the patch - looks good to me. I wonder if it would make sense to do some cleanup in the code (final vars and args etc.) and if we should remove this logging code. It makes sense to use logging but afaik there is no ultimate logging api in lucene so i would rather go for removing the logging code before we release. Is that worth a new issue?!
simon
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1505) Change contrib/spatial to use trie's
NumericUtils, and remove NumberUtils
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1505:
------------------------------------------
Assignee: Michael McCandless (was: Simon Willnauer)
I'll take this one, if you haven't started on it Simon...
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1505) Remove NumberUtils from spatial
contrib
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720572#action_12720572 ]
Michael McCandless commented on LUCENE-1505:
--------------------------------------------
LUCENE-1496 is "won't fix" because trie's NumericUtils subsumes Solr's NumberUtils, ie, we now need to migrate local lucene to NumericUtils. And we want to do this for 2.9, since local lucene is not yet released and we have the freedom to make such an otherwise drastic change to the index format.
I'll update this issue to reflect it's new goal.
> Remove NumberUtils from spatial contrib
> ---------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Simon Willnauer
> Fix For: 2.9
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org