You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2010/08/04 00:18:08 UTC

DO NOT REPLY [Bug 49695] New: [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

https://issues.apache.org/bugzilla/show_bug.cgi?id=49695

           Summary: [PATCH] Fop - replaced vars w UnitConv and
                    GraphicsConstants
           Product: Fop
           Version: all
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: general
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: joshua.marquart@firstdata.com


Created an attachment (id=25833)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25833)
Replaces many variables with constants from UnitConv and GraphicsConstants

Replace several variable constants with appropriate constants from xmlgraphics
UnitConv and GraphicsConstants.

Searched on 25.4, 2.54, and 72 (for both UnitConv and GraphicsConstants)

Questions regarding additional constants:

1) UnitConv vs. org.apache.fop.fo.properties.FixedLength 
FixedLength contains redundant constants.  Fix?

2) Variable 72000 is used in multiple places in conjunction with variable 300. 
Fix?

3) PCL uses var 300 many times; no constant set to represent as default.
Fix?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49695] [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695

Vincent Hennebert <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Vincent Hennebert <vh...@gmail.com> 2010-11-23 14:26:52 EST ---
Patch applied in rev. 1038291.
http://svn.apache.org/viewvc?rev=1038291&view=rev
Thanks for your contribution and sorry for the delay.

I made the following modifications:
• PDFRenderer: the normal resolution is and will always be 72dpi.
GraphicsConstants.DEFAULT_DPI might very well change to something else than
72dpi in the future;
• AFPConstants: left it to 72 for the same reason;
• ImageConverterSVG2G2D: divide by DEFAULT_DPI and not IN2PT. Physically the
same, logically different.

Thanks,
Vincent

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49695] [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695

Joshua Marquart <jo...@firstdata.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P5

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49695] [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Glenn Adams <gl...@skynav.com> 2012-04-01 06:16:07 UTC ---
batch transition to closed; if someone wishes to restore one of these to
resolved in order to perform a verification step, then feel free to do so

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49695] [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695

--- Comment #1 from Joshua Marquart <jo...@firstdata.com> 2010-08-03 18:20:05 EDT ---
Future similar patch to be applied to xmlgraphics.

Also moved FOP reference to FOP UnitConv to use xmlgraphics UnitConv

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.