You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2017/09/19 19:57:23 UTC

svn commit: r1808939 - /commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java

Author: ggregory
Date: Tue Sep 19 19:57:23 2017
New Revision: 1808939

URL: http://svn.apache.org/viewvc?rev=1808939&view=rev
Log:
[VFS-291] ZIP archives are not properly closed after unzipping and cannot be deleted until the JVM exists. Do not close underlying ZipFile too aggressively; only do so if all open streams are not in use!

Modified:
    commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java

Modified: commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java?rev=1808939&r1=1808938&r2=1808939&view=diff
==============================================================================
--- commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java (original)
+++ commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java Tue Sep 19 19:57:23 2017
@@ -138,12 +138,11 @@ public class ZipFileObjectTestCase {
 
     /**
      * Tests that we can get a stream from one file in a zip file, then close another file from the same zip, then
-     * process the initial input stream.
+     * process the initial input stream. If our internal reference counting is correct, the test passes.
      *
      * @throws IOException
      */
     @Test
-    @Ignore("Trying to duplicate what I seeing using JAXP")
     public void testReadingOneAfterClosingAnotherStream() throws IOException {
         final File newZipFile = createTempFile();
         final FileSystemManager manager = VFS.getManager();