[GitHub] [incubator-doris] mrhhsg commented on a diff in pull request #9663: [Enhancement]Add prefetch in join node

[GitBox <gi...@apache.org>]

mrhhsg commented on code in PR #9663:
URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r881109495


##########
be/src/vec/common/hash_table/hash_table_key_holder.h:
##########
@@ -120,7 +120,7 @@ namespace doris::vectorized {
   */
 struct SerializedKeyHolder {
     StringRef key;
-    Arena& pool;
+    Arena* pool;

Review Comment:
   To avoid calling `get_key_holder` for each row twice, `KeyHolder` should be cached in a vector, but `SerializedKeyHolder` contains reference of Arena cannot be copied into the vector.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org