You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2016/11/12 16:52:19 UTC
Struts 2.5.6
Hi,
I think we are good to go, 13 issues were resolved. Do you have
anything else to be resolved beforehand?
https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20fixVersion%20%3D%202.5.6
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.6
Posted by Greg Huber <gr...@gmail.com>.
Not sure this one can be fixed as it is a "didn't match accepted pattern"
rather than a "matches excluded pattern". If you do the same mod as the
DefaultExcludedPatternsChecker the ParametersInterceptor tries to set the
property (Error setting expression 'action:myAction!save) and fails. Not
worth the pain.
Cheers
On 15 November 2016 at 09:21, Lukasz Lenart <lu...@apache.org> wrote:
> but do you use DMI? I meant, did you enable DMI?
>
> 2016-11-14 12:43 GMT+01:00 Greg Huber <gr...@gmail.com>:
> > I do not know if its the snapshot version I now get lots of these in my
> > logs again
> >
> > 2016-11-14 11:39:45,621 WARN
> > com.opensymphony.xwork2.interceptor.ParametersInterceptor
> > ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
> > didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
> > \))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
> >
> > Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
> >
> > On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org>
> wrote:
> >
> >> Hi,
> >>
> >> I think we are good to go, 13 issues were resolved. Do you have
> >> anything else to be resolved beforehand?
> >> https://issues.apache.org/jira/issues/?jql=project%20%
> >> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
> >>
> >>
> >> Regards
> >> --
> >> Łukasz
> >> + 48 606 323 122 http://www.lenart.org.pl/
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.5.6
Posted by Lukasz Lenart <lu...@apache.org>.
I think we are good to go with the latest release, I'm going to
prepare a test build of 2.5.6
2016-11-16 10:15 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> Please try the latest build, I have pushed some changes
>
> 2016-11-16 10:09 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
>> Hmm... maybe instead of using this switch, just log those messages in
>> DEBUG only...
>>
>> 2016-11-15 10:33 GMT+01:00 Greg Huber <gr...@gmail.com>:
>>> ParametersInterceptor ignores dmi??
>>>
>>> protected boolean isAccepted(String paramName) {
>>> AcceptedPatternsChecker.IsAccepted result =
>>> acceptedPatterns.isAccepted(paramName);
>>> if (result.isAccepted()) {
>>> return true;
>>> }
>>> notifyDeveloper("Parameter [{}] didn't match accepted pattern
>>> [{}]!", paramName, result.getAcceptedPattern());
>>> return false;
>>> }
>>>
>>> private void notifyDeveloper(String message, String... parameters) {
>>> if (devMode) {
>>> LOG.warn(message, parameters);
>>> } else {
>>> LOG.debug(message, parameters);
>>> }
>>> }
>>>
>>> On 15 November 2016 at 09:21, Lukasz Lenart <lu...@apache.org> wrote:
>>>
>>>> but do you use DMI? I meant, did you enable DMI?
>>>>
>>>> 2016-11-14 12:43 GMT+01:00 Greg Huber <gr...@gmail.com>:
>>>> > I do not know if its the snapshot version I now get lots of these in my
>>>> > logs again
>>>> >
>>>> > 2016-11-14 11:39:45,621 WARN
>>>> > com.opensymphony.xwork2.interceptor.ParametersInterceptor
>>>> > ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
>>>> > didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
>>>> > \))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
>>>> >
>>>> > Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
>>>> >
>>>> > On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org>
>>>> wrote:
>>>> >
>>>> >> Hi,
>>>> >>
>>>> >> I think we are good to go, 13 issues were resolved. Do you have
>>>> >> anything else to be resolved beforehand?
>>>> >> https://issues.apache.org/jira/issues/?jql=project%20%
>>>> >> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
>>>> >>
>>>> >>
>>>> >> Regards
>>>> >> --
>>>> >> Łukasz
>>>> >> + 48 606 323 122 http://www.lenart.org.pl/
>>>> >>
>>>> >> ---------------------------------------------------------------------
>>>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> >> For additional commands, e-mail: dev-help@struts.apache.org
>>>> >>
>>>> >>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>
>>
>>
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.6
Posted by Lukasz Lenart <lu...@apache.org>.
Please try the latest build, I have pushed some changes
2016-11-16 10:09 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> Hmm... maybe instead of using this switch, just log those messages in
> DEBUG only...
>
> 2016-11-15 10:33 GMT+01:00 Greg Huber <gr...@gmail.com>:
>> ParametersInterceptor ignores dmi??
>>
>> protected boolean isAccepted(String paramName) {
>> AcceptedPatternsChecker.IsAccepted result =
>> acceptedPatterns.isAccepted(paramName);
>> if (result.isAccepted()) {
>> return true;
>> }
>> notifyDeveloper("Parameter [{}] didn't match accepted pattern
>> [{}]!", paramName, result.getAcceptedPattern());
>> return false;
>> }
>>
>> private void notifyDeveloper(String message, String... parameters) {
>> if (devMode) {
>> LOG.warn(message, parameters);
>> } else {
>> LOG.debug(message, parameters);
>> }
>> }
>>
>> On 15 November 2016 at 09:21, Lukasz Lenart <lu...@apache.org> wrote:
>>
>>> but do you use DMI? I meant, did you enable DMI?
>>>
>>> 2016-11-14 12:43 GMT+01:00 Greg Huber <gr...@gmail.com>:
>>> > I do not know if its the snapshot version I now get lots of these in my
>>> > logs again
>>> >
>>> > 2016-11-14 11:39:45,621 WARN
>>> > com.opensymphony.xwork2.interceptor.ParametersInterceptor
>>> > ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
>>> > didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
>>> > \))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
>>> >
>>> > Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
>>> >
>>> > On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org>
>>> wrote:
>>> >
>>> >> Hi,
>>> >>
>>> >> I think we are good to go, 13 issues were resolved. Do you have
>>> >> anything else to be resolved beforehand?
>>> >> https://issues.apache.org/jira/issues/?jql=project%20%
>>> >> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
>>> >>
>>> >>
>>> >> Regards
>>> >> --
>>> >> Łukasz
>>> >> + 48 606 323 122 http://www.lenart.org.pl/
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> For additional commands, e-mail: dev-help@struts.apache.org
>>> >>
>>> >>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>
>
>
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.6
Posted by Lukasz Lenart <lu...@apache.org>.
Hmm... maybe instead of using this switch, just log those messages in
DEBUG only...
2016-11-15 10:33 GMT+01:00 Greg Huber <gr...@gmail.com>:
> ParametersInterceptor ignores dmi??
>
> protected boolean isAccepted(String paramName) {
> AcceptedPatternsChecker.IsAccepted result =
> acceptedPatterns.isAccepted(paramName);
> if (result.isAccepted()) {
> return true;
> }
> notifyDeveloper("Parameter [{}] didn't match accepted pattern
> [{}]!", paramName, result.getAcceptedPattern());
> return false;
> }
>
> private void notifyDeveloper(String message, String... parameters) {
> if (devMode) {
> LOG.warn(message, parameters);
> } else {
> LOG.debug(message, parameters);
> }
> }
>
> On 15 November 2016 at 09:21, Lukasz Lenart <lu...@apache.org> wrote:
>
>> but do you use DMI? I meant, did you enable DMI?
>>
>> 2016-11-14 12:43 GMT+01:00 Greg Huber <gr...@gmail.com>:
>> > I do not know if its the snapshot version I now get lots of these in my
>> > logs again
>> >
>> > 2016-11-14 11:39:45,621 WARN
>> > com.opensymphony.xwork2.interceptor.ParametersInterceptor
>> > ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
>> > didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
>> > \))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
>> >
>> > Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
>> >
>> > On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> I think we are good to go, 13 issues were resolved. Do you have
>> >> anything else to be resolved beforehand?
>> >> https://issues.apache.org/jira/issues/?jql=project%20%
>> >> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
>> >>
>> >>
>> >> Regards
>> >> --
>> >> Łukasz
>> >> + 48 606 323 122 http://www.lenart.org.pl/
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> For additional commands, e-mail: dev-help@struts.apache.org
>> >>
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.6
Posted by Greg Huber <gr...@gmail.com>.
ParametersInterceptor ignores dmi??
protected boolean isAccepted(String paramName) {
AcceptedPatternsChecker.IsAccepted result =
acceptedPatterns.isAccepted(paramName);
if (result.isAccepted()) {
return true;
}
notifyDeveloper("Parameter [{}] didn't match accepted pattern
[{}]!", paramName, result.getAcceptedPattern());
return false;
}
private void notifyDeveloper(String message, String... parameters) {
if (devMode) {
LOG.warn(message, parameters);
} else {
LOG.debug(message, parameters);
}
}
On 15 November 2016 at 09:21, Lukasz Lenart <lu...@apache.org> wrote:
> but do you use DMI? I meant, did you enable DMI?
>
> 2016-11-14 12:43 GMT+01:00 Greg Huber <gr...@gmail.com>:
> > I do not know if its the snapshot version I now get lots of these in my
> > logs again
> >
> > 2016-11-14 11:39:45,621 WARN
> > com.opensymphony.xwork2.interceptor.ParametersInterceptor
> > ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
> > didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
> > \))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
> >
> > Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
> >
> > On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org>
> wrote:
> >
> >> Hi,
> >>
> >> I think we are good to go, 13 issues were resolved. Do you have
> >> anything else to be resolved beforehand?
> >> https://issues.apache.org/jira/issues/?jql=project%20%
> >> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
> >>
> >>
> >> Regards
> >> --
> >> Łukasz
> >> + 48 606 323 122 http://www.lenart.org.pl/
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.5.6
Posted by Lukasz Lenart <lu...@apache.org>.
but do you use DMI? I meant, did you enable DMI?
2016-11-14 12:43 GMT+01:00 Greg Huber <gr...@gmail.com>:
> I do not know if its the snapshot version I now get lots of these in my
> logs again
>
> 2016-11-14 11:39:45,621 WARN
> com.opensymphony.xwork2.interceptor.ParametersInterceptor
> ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
> didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
> \))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
>
> Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
>
> On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org> wrote:
>
>> Hi,
>>
>> I think we are good to go, 13 issues were resolved. Do you have
>> anything else to be resolved beforehand?
>> https://issues.apache.org/jira/issues/?jql=project%20%
>> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.6
Posted by Greg Huber <gr...@gmail.com>.
I do not know if its the snapshot version I now get lots of these in my
logs again
2016-11-14 11:39:45,621 WARN
com.opensymphony.xwork2.interceptor.ParametersInterceptor
ParametersInterceptor:notifyDeveloper - Parameter [action:myaction!save]
didn't match accepted pattern [[\w+((\.\w+)|(\[\d+\])|(\(\d+
\))|(\['(\w|[\u4e00-\u9fa5])+'\])|(\('(\w|[\u4e00-\u9fa5])+'\)))*]]!
Sure this was fixed on https://issues.apache.org/jira/browse/WW-4697
On 12 November 2016 at 16:52, Lukasz Lenart <lu...@apache.org> wrote:
> Hi,
>
> I think we are good to go, 13 issues were resolved. Do you have
> anything else to be resolved beforehand?
> https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20WW%20AND%20fixVersion%20%3D%202.5.6
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>