You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/04 14:18:59 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11513: [Clean up] Remove the unused variable maximumRolloverTimeMs

codelipenghui commented on a change in pull request #11513:
URL: https://github.com/apache/pulsar/pull/11513#discussion_r682661391



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -305,8 +304,6 @@ public ManagedLedgerImpl(ManagedLedgerFactoryImpl factory, BookKeeper bookKeeper
         this.uninitializedCursors = Maps.newHashMap();
         this.clock = config.getClock();
 
-        // Get the next rollover time. Add a random value upto 5% to avoid rollover multiple ledgers at the same time
-        this.maximumRolloverTimeMs = getMaximumRolloverTimeMs(config);

Review comment:
       Yes, I think we should use the `maximumRolloverTimeMs`, and should avoid the `updateLastLedgerCreatedTimeAndScheduleRolloverTask` method to compute the `maximumRolloverTimeMs` for every check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org