You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/26 09:26:42 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #7071: [INLONG-7070][Manager][DataProxy] Fix mq configuration dispatching problem
woofyzhao opened a new pull request, #7071:
URL: https://github.com/apache/inlong/pull/7071
- Fixes #7070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #7071: [INLONG-7070][Manager][DataProxy] Fix mq configuration dispatching problem
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #7071:
URL: https://github.com/apache/inlong/pull/7071#discussion_r1057193311
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/DataProxyConfigRepository.java:
##########
@@ -385,7 +385,8 @@ private Map<String, List<InLongIdObject>> parseInlongId(Map<String, InlongGroupI
InlongStreamId streamIdObj = entry.getValue();
String groupId = streamIdObj.getInlongGroupId();
InlongGroupId groupIdObj = groupIdMap.get(groupId);
- if (groupId == null) {
+ if (groupId == null || groupIdObj == null) {
+ LOGGER.warn("groupId {} or groupIdObj {} is null, ignored", groupId, groupIdObj);
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7071: [INLONG-7070][Manager][DataProxy] Fix mq configuration dispatching problem
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7071:
URL: https://github.com/apache/inlong/pull/7071#discussion_r1057215146
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneProducer.java:
##########
@@ -107,6 +107,7 @@ public void run() {
*/
public void reload() {
try {
+ LOG.info("start reload mq clusters");
Review Comment:
This log seems has not enough info, will this log output too much?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #7071: [INLONG-7070][Manager][DataProxy] Fix mq configuration dispatching problem
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #7071:
URL: https://github.com/apache/inlong/pull/7071#discussion_r1057418076
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneProducer.java:
##########
@@ -107,6 +107,7 @@ public void run() {
*/
public void reload() {
try {
+ LOG.info("start reload mq clusters");
Review Comment:
no, low frequency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #7071: [INLONG-7070][Manager][DataProxy] Fix mq configuration dispatching problem
Posted by GitBox <gi...@apache.org>.
vernedeng commented on code in PR #7071:
URL: https://github.com/apache/inlong/pull/7071#discussion_r1057186127
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/DataProxyConfigRepository.java:
##########
@@ -385,7 +385,8 @@ private Map<String, List<InLongIdObject>> parseInlongId(Map<String, InlongGroupI
InlongStreamId streamIdObj = entry.getValue();
String groupId = streamIdObj.getInlongGroupId();
InlongGroupId groupIdObj = groupIdMap.get(groupId);
- if (groupId == null) {
+ if (groupId == null || groupIdObj == null) {
+ LOGGER.warn("groupId {} or groupIdObj {} is null, ignored", groupId, groupIdObj);
Review Comment:
It is better to set logging level to **_debug_**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7071: [INLONG-7070][Manager][DataProxy] Fix mq configuration dispatching problem
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #7071:
URL: https://github.com/apache/inlong/pull/7071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org