You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/17 01:36:57 UTC

[PR] refactor(build-tooling): idiomatic Groovy cleanup of the J2G output [grails-core]

borinquenkid opened a new pull request, #16661:
URL: https://github.com/apache/grails-core/pull/16661

   Stacks on #16576 (java-to-groovy conversion for `build-logic/docs-core` and `grails-gradle/common`+`model`).
   
   Behaviour-preserving idiom pass over that conversion's output (14 of the 35 files in scope; the rest were already idiomatic or are interfaces/DTOs left untouched).
   
   **Applied**
   - Property syntax for unambiguous getters (`Class.getName()` → `.name`, `URL`/`File`/`URLConnection`/`Throwable`/`Resource` accessors, `Class.isArray()`/`.getComponentType()` → `.array`/`.componentType`)
   - Map-read subscript (`map.get(k)` → `map[k]`)
   - `.equals()` on Strings → `==`
   - `str.length() == 0` → `isEmpty()`
   - `StringBuilder.append(` → `<<`
   - String concatenation → GString where it lands in a `String`-typed slot
   - Dropped redundant casts after `instanceof` flow typing
   - `x != null ? x.foo() : null` → `x?.foo()`
   - `for (X x : coll)` → `for (X x in coll)`
   - Dropped an unnecessary `public` modifier on `StringEscapeCategory`'s static methods
   
   **Deliberately left** (documented per-site in the commit body): `Environment.getName()` (shadows `Enum.name()` differently), `DefaultResourceLoader.getClassLoader()` field-priority call, a closure-shared-variable cast the type checker rejects dropping, `Class.newInstance()` (avoids widening a public API's checked-exception surface), `SpringIOUtils`'s `in`/`out` parameter names across ~8 overloads (real Tier-A hit, judged disproportionate as a standalone rename), `ClassPathResource#nullSafeEquals`'s `.equals()` on an `Object` that may be an array, trivial getter/setter pairs that would add a public setter that doesn't exist today, and one Javadoc-bearing getter.
   
   **Found during verification**: `map[k] = v` (subscript assignment) compiles to a dynamic `ScriptBytecodeAdapter.invokeMethodN("putAt", ...)` call under `@CompileStatic` here, unlike the read form which resolves statically. All ~10 sites introduced by this pass were reverted back to `.put(k, v)`; the read-only subscript conversions were kept.
   
   This revision also carries forward the rename-compliance fix from #16576 (`DefaultCommandLine.groovy` keeping semicolons temporarily) merged and resolved to its fully idiomatic end state — the semicolons and the `@SuppressWarnings` from that fix are removed here, completing the 3-stage conversion→cleanup split for that file.
   
   **Verification**
   - `build-logic`: compile/test green (`StringEscapeCategorySpec` 2/2; one pre-existing, unrelated `FetchTagsTaskSpec` sandbox failure)
   - `grails-gradle`: compile green for `common`+`model`; `codeStyle` 0 CodeNarc violations; full `test` 456/456, 0 failures
   - `javap -c -p` dynamic-dispatch audit clean on every changed class after the `putAt` fix
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(build-tooling): idiomatic Groovy cleanup of the J2G output [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid closed pull request #16661: refactor(build-tooling): idiomatic Groovy cleanup of the J2G output
URL: https://github.com/apache/grails-core/pull/16661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(build-tooling): idiomatic Groovy cleanup of the J2G output [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid commented on PR #16661:
URL: https://github.com/apache/grails-core/pull/16661#issuecomment-6282026979

   **BLOCKER before merge: this branch carries a temporary CI commit.**
   
   This PR is stacked, and to avoid starting a full CI matrix on every push or rebase of the stack it carries one temporary commit, `CHANGEME FOR ACCEPTANCE: disable PR workflow triggers`. It changes the `pull_request:` trigger of 13 workflows to `branches: ['CHANGEME-FOR-ACCEPTANCE']`, a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.
   
   **Condition for merging this PR:** that commit must be reverted on this branch first, and CI must then run and be green. **The absence of CI checks on this PR is deliberate and does not mean the code was tested.** The full build runs on #16576 and #16572, the PRs that target 10.0.x.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(build-tooling): idiomatic Groovy cleanup of the J2G output [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid commented on PR #16661:
URL: https://github.com/apache/grails-core/pull/16661#issuecomment-6375206314

   Superseded by #16744: the conversion there is already in the final style, so the idiom pass of this pull request is part of it, and its files are moved in a commit of their own so their history is followed. Closing; the branch stays for reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org