[jira] [Commented] (PIG-4714) Improve logging across multiple components with callerId

["Xiang Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253752#comment-15253752 ] 

Xiang Li commented on PIG-4714:
-------------------------------

Hi Daniel, I am trying to put your patch into our 0.15.0 build, by using "patch -p1 < xxx/PIG-4714-1.patch", and have something wrong:
{code}
patching file src/hadoop20/org/apache/pig/backend/hadoop/ATSService.java
patching file src/hadoop23/org/apache/pig/backend/hadoop/ATSService.java
can't find file to patch at input line 180
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: src/org/apache/pig/PigConfiguration.java
|===================================================================
|--- src/org/apache/pig/PigConfiguration.java	(revision 1710711)
|+++ src/org/apache/pig/PigConfiguration.java	(working copy)
--------------------------
File to patch: 
{code}

I am confused why shims/src/hadoop20/org/apache/pig/backend/hadoop/ATSService.java is changed into src/hadoop20/org/apache/pig/backend/hadoop/ATSService.java
The parent folder "shims" is lost.


> Improve logging across multiple components with callerId
> --------------------------------------------------------
>
>                 Key: PIG-4714
>                 URL: https://issues.apache.org/jira/browse/PIG-4714
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.16.0
>
>         Attachments: PIG-4714-1.patch
>
>
> The idea is to add callerId to every component, so we can track the chain of application which cause the underlining operation. A typical chain is Oozie->Pig->Tez->Hdfs. With proper callerId logging, we can trace Hdfs operation back to Oozie workflow which triggers it.
> The protocol we decided is every component log its immediate callerId. 
> For Pig, this includes passing Pig script ID to underlining components as callerId using component specific API, log callerId of Pig and store it on ATS. More specific, it includes:
> 1. Generate a CallerId for each Pig script, pass it to Hdfs/Yarn/MapReduce/Tez which Pig invokes
> 2. Pig caller passes "pig.log.trace.id" to Pig, Pig will publish it to ATS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)