You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/10/10 13:44:46 UTC

Review Request 62864: Disabled Pylint error messages for apply-reviews support script.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62864/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-8066
    https://issues.apache.org/jira/browse/MESOS-8066


Repository: mesos


Description
-------

This disables the error messages we have seen on CentOS when the
version of Python running on the machine is older than 2.7.9. The
two error messages concern only Windows, thus the support script
requires Python >= 2.7.9 on that operating system to be used.


Diffs
-----

  docs/executor-http-api.md f03b8f29264adc73cdf361bb6912a434c2178c8b 
  include/mesos/mesos.proto 830985a3265b7c104d8fdc50749c395d98f5f3c8 
  include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
  src/common/resources.cpp 7ee4dae1389e037531aec533a3d235ee06443ea8 
  src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 
  src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 
  src/tests/resources_tests.cpp 64bde85e0e7f0bd395189eb6a8635383095b2f07 
  src/v1/resources.cpp 5c0a196cf87b377b345e53a36ed24727d52381ca 
  src/webui/master/static/js/controllers.js fa0ad54cbcec7a3b0bea9e2b0dc70a4c3f41e822 
  support/apply-reviews.py 23f20477f7edb1d7932630012a411d28c2720747 


Diff: https://reviews.apache.org/r/62864/diff/1/


Testing
-------


Thanks,

Armand Grillet


Re: Review Request 62864: Disabled Pylint error messages for apply-reviews support script.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62864/#review187551
-----------------------------------------------------------



PASS: Mesos patch 62864 was successfully built and tested.

Reviews applied: `['62864']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62864

- Mesos Reviewbot Windows


On Oct. 10, 2017, 1:44 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62864/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 1:44 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-8066
>     https://issues.apache.org/jira/browse/MESOS-8066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This disables the error messages we have seen on CentOS when the
> version of Python running on the machine is older than 2.7.9. The
> two error messages concern only Windows, thus the support script
> requires Python >= 2.7.9 on that operating system to be used.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 23f20477f7edb1d7932630012a411d28c2720747 
> 
> 
> Diff: https://reviews.apache.org/r/62864/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Re: Review Request 62864: Disabled Pylint error messages for apply-reviews support script.

Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62864/#review187671
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Oct. 10, 2017, 1:44 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62864/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 1:44 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-8066
>     https://issues.apache.org/jira/browse/MESOS-8066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This disables the error messages we have seen on CentOS when the
> version of Python running on the machine is older than 2.7.9. The
> two error messages concern only Windows, thus the support script
> requires Python >= 2.7.9 on that operating system to be used.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 23f20477f7edb1d7932630012a411d28c2720747 
> 
> 
> Diff: https://reviews.apache.org/r/62864/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Re: Review Request 62864: Disabled Pylint error messages for apply-reviews support script.

Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62864/#review187672
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Oct. 10, 2017, 1:44 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62864/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 1:44 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-8066
>     https://issues.apache.org/jira/browse/MESOS-8066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This disables the error messages we have seen on CentOS when the
> version of Python running on the machine is older than 2.7.9. The
> two error messages concern only Windows, thus the support script
> requires Python >= 2.7.9 on that operating system to be used.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 23f20477f7edb1d7932630012a411d28c2720747 
> 
> 
> Diff: https://reviews.apache.org/r/62864/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>