You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2018/07/07 20:11:00 UTC
[jira] [Updated] (WICKET-6563) Rework page and data storage
[ https://issues.apache.org/jira/browse/WICKET-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier updated WICKET-6563:
-------------------------------
Description:
IPageManager, IPageStore and IDataStore are riddled with complicated and error-prone code aiming to do one simple thing: keeping pages around.
There are multiple problems with the current implementation:
* PageStoreManger does too muchÂ
** it handles request and session storage
** it contains workarounds for DiskDataStore, when the sessionId changes
* IPageStore/AbstractPageStore
** has no access to IPageManagerContext
** juggles with byte[], serialization and conversion
* IDataStore introduces an unncecessary third layer into the API
Additional or specialized stores are difficult to implement.
We should rework that.
was:
IPageManager, IPageStore and IDataStore are riddled with complicated and error-prone code aiming to do one simple thing: keeping pages around.
We should rework that.
> Rework page and data storage
> ----------------------------
>
> Key: WICKET-6563
> URL: https://issues.apache.org/jira/browse/WICKET-6563
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 9.0.0
> Reporter: Sven Meier
> Assignee: Sven Meier
> Priority: Minor
>
> IPageManager, IPageStore and IDataStore are riddled with complicated and error-prone code aiming to do one simple thing: keeping pages around.
> There are multiple problems with the current implementation:
> * PageStoreManger does too muchÂ
> ** it handles request and session storage
> ** it contains workarounds for DiskDataStore, when the sessionId changes
> * IPageStore/AbstractPageStore
> ** has no access to IPageManagerContext
> ** juggles with byte[], serialization and conversion
> * IDataStore introduces an unncecessary third layer into the API
> Additional or specialized stores are difficult to implement.
> We should rework that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [jira] [Updated] (WICKET-6563) Rework page and data storage
Posted by Andrea Del Bene <an...@gmail.com>.
Nice job Sven! I will try to review your changes ASAP.
Thnak you.
On Sat, Jul 7, 2018 at 10:11 PM, Sven Meier (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/WICKET-6563?page=
> com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Sven Meier updated WICKET-6563:
> -------------------------------
> Description:
> IPageManager, IPageStore and IDataStore are riddled with complicated and
> error-prone code aiming to do one simple thing: keeping pages around.
>
> There are multiple problems with the current implementation:
> * PageStoreManger does too much
> ** it handles request and session storage
> ** it contains workarounds for DiskDataStore, when the sessionId changes
> * IPageStore/AbstractPageStore
> ** has no access to IPageManagerContext
> ** juggles with byte[], serialization and conversion
> * IDataStore introduces an unncecessary third layer into the API
>
> Additional or specialized stores are difficult to implement.
>
> We should rework that.
>
> was:
> IPageManager, IPageStore and IDataStore are riddled with complicated and
> error-prone code aiming to do one simple thing: keeping pages around.
>
> We should rework that.
>
>
> > Rework page and data storage
> > ----------------------------
> >
> > Key: WICKET-6563
> > URL: https://issues.apache.org/jira/browse/WICKET-6563
> > Project: Wicket
> > Issue Type: Improvement
> > Components: wicket
> > Affects Versions: 9.0.0
> > Reporter: Sven Meier
> > Assignee: Sven Meier
> > Priority: Minor
> >
> > IPageManager, IPageStore and IDataStore are riddled with complicated and
> error-prone code aiming to do one simple thing: keeping pages around.
> > There are multiple problems with the current implementation:
> > * PageStoreManger does too much
> > ** it handles request and session storage
> > ** it contains workarounds for DiskDataStore, when the sessionId changes
> > * IPageStore/AbstractPageStore
> > ** has no access to IPageManagerContext
> > ** juggles with byte[], serialization and conversion
> > * IDataStore introduces an unncecessary third layer into the API
> > Additional or specialized stores are difficult to implement.
> > We should rework that.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
--
Andrea Del Bene.
Apache Wicket committer.