You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Jason Pyeron (Jira)" <ji...@apache.org> on 2019/11/21 19:46:00 UTC

[jira] [Created] (PDFBOX-4695) PDPropBuildDataDict missing setNonEFontNoWarn

Jason Pyeron created PDFBOX-4695:
------------------------------------

             Summary: PDPropBuildDataDict missing setNonEFontNoWarn
                 Key: PDFBOX-4695
                 URL: https://issues.apache.org/jira/browse/PDFBOX-4695
             Project: PDFBox
          Issue Type: Improvement
    Affects Versions: 2.0.15
            Reporter: Jason Pyeron
             Fix For: 2.0.18, 3.0.0 PDFBox
         Attachments: patch.patch





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


RE: [jira] [Created] (PDFBOX-4695) PDPropBuildDataDict missing setNonEFontNoWarn

Posted by Jason Pyeron <jp...@pdinc.us>.
Thinking that COSName parameter should be exposed too, instead of misleading the notion that it is a string and auto converting it behind the scene.

There are peers (Rex and Date) which are strings, proper.

Thoughts?

diff --git a/cresaptown-approval-frontend/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/PDPropBuildDataDict.java b/cresaptown-approval-frontend/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/PDPropBuildDataDict.java
index 38eabdcb..9b0785ef 100755
--- a/cresaptown-approval-frontend/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/PDPropBuildDataDict.java
+++ b/cresaptown-approval-frontend/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/PDPropBuildDataDict.java
@@ -78,12 +78,23 @@ public class PDPropBuildDataDict implements COSObjectable
      * The name of the software module that was used to create the signature.
      *
      * @param name is the name of the software module
+     * @see #setName(COSName)
      */
     public void setName(String name)
     {
         dictionary.setName(COSName.NAME, name);
     }

+    /**
+     * The name of the software module that was used to create the signature.
+     *
+     * @param name is the name of the software module
+     */
+    public void setName(COSName name)
+    {
+        dictionary.setItem(COSName.NAME, name);
+    }
+
     /**
      * The build date of the software module. This string is normally produced by the compiler that
      * is used to compile the software, for example using the Date and Time preprocessor flags. As


> -----Original Message-----
> From: Jason Pyeron (Jira) <ji...@apache.org>
> Sent: Thursday, November 21, 2019 2:46 PM
> To: dev@pdfbox.apache.org
> Subject: [jira] [Created] (PDFBOX-4695) PDPropBuildDataDict missing setNonEFontNoWarn
> 
> Jason Pyeron created PDFBOX-4695:
> ------------------------------------
> 
>              Summary: PDPropBuildDataDict missing setNonEFontNoWarn
>                  Key: PDFBOX-4695
>                  URL: https://issues.apache.org/jira/browse/PDFBOX-4695
>              Project: PDFBox
>           Issue Type: Improvement
>     Affects Versions: 2.0.15
>             Reporter: Jason Pyeron
>              Fix For: 2.0.18, 3.0.0 PDFBox
>          Attachments: patch.patch
> 
> 
> 
> 
> 
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
> For additional commands, e-mail: dev-help@pdfbox.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org