You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/10 13:29:53 UTC

[GitHub] [rocketmq] gylang opened a new issue #3243: use the StringBuilder another method can reduce impact on array copy performance

gylang opened a new issue #3243:
URL: https://github.com/apache/rocketmq/issues/3243


   i think use the StringBuilder another method can reduce impact on array copy performance
   ![image](https://user-images.githubusercontent.com/41338363/128875256-900f6316-f17a-4957-ae7d-53ce2a8e9828.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] caigy commented on issue #3243: use the StringBuilder another method can reduce impact on array copy performance

Posted by GitBox <gi...@apache.org>.
caigy commented on issue #3243:
URL: https://github.com/apache/rocketmq/issues/3243#issuecomment-919672587


   @gylang The call to`messagePattern.substring()` is redundant, could you submit a PR to fix it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhiboo commented on issue #3243: use the StringBuilder another method can reduce impact on array copy performance

Posted by GitBox <gi...@apache.org>.
lizhiboo commented on issue #3243:
URL: https://github.com/apache/rocketmq/issues/3243#issuecomment-897463732


   @gylang  Good catch, can u submit a pr to optimize it？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] gylang commented on issue #3243: use the StringBuilder another method can reduce impact on array copy performance

Posted by GitBox <gi...@apache.org>.
gylang commented on issue #3243:
URL: https://github.com/apache/rocketmq/issues/3243#issuecomment-896493545


   ![image](https://user-images.githubusercontent.com/41338363/128970167-20cbf379-396f-4724-9e2b-354d017b6476.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhaohai1299002788 commented on issue #3243: use the StringBuilder another method can reduce impact on array copy performance

Posted by GitBox <gi...@apache.org>.
zhaohai1299002788 commented on issue #3243:
URL: https://github.com/apache/rocketmq/issues/3243#issuecomment-896430932


   Please give an example of the specific code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org