[jira] [Resolved] (HIVE-28140) Remove unnecessary shading of test jars in Kafka module to speedup build

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-28140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis resolved HIVE-28140.
----------------------------------------
    Fix Version/s: 4.1.0
       Resolution: Fixed

Fixed in [https://github.com/apache/hive/commit/9a0ce4e15890aa91f05322e845438e1e8830b1c3]

Thanks for the review [~zhangbutao] !

> Remove unnecessary shading of test jars in Kafka module to speedup build
> ------------------------------------------------------------------------
>
>                 Key: HIVE-28140
>                 URL: https://issues.apache.org/jira/browse/HIVE-28140
>             Project: Hive
>          Issue Type: Task
>          Components: kafka integration
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.1.0
>
>         Attachments: mvnout.txt
>
>
> When the [shadeTestJar|https://github.com/apache/hive/blob/884981d1788c6966e895e2959ed954a22eb5c5eb/kafka-handler/pom.xml#L179] option is enabled it tries to fetch the test jars from all dependencies and include them in the shaded artifact.
> For every dependency, and every available repository, there is a download attempt that fails most of the time (since most dependencies do not publish the test artifacts).
> {noformat}
> Downloading from confluent: https://packages.confluent.io/maven/com/sun/jersey/contribs/jersey-guice/1.19.4/jersey-guice-1.19.4-tests.jar
> Downloading from central: https://repo.maven.apache.org/maven2/com/sun/jersey/contribs/jersey-guice/1.19.4/jersey-guice-1.19.4-tests.jar
> Downloading from repository-release: https://repository.apache.org/content/repositories/releases/com/sun/jersey/contribs/jersey-guice/1.19.4/jersey-guice-1.19.4-tests.jar
> Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/com/sun/jersey/contribs/jersey-guice/1.19.4/jersey-guice-1.19.4-tests.jar
> [WARNING] Could not get tests for com.sun.jersey.contribs:jersey-guice:jar:1.19.4:compile
> {noformat}
> All these download attempts increase build time noticeably, especially on slow internet connections.
> Shading the test jars in Kafka module is not necessary since we are not using the resulting jars (kafka-handler-4.1.0-SNAPSHOT-tests.jar) anywhere inside the project (no occurrence of kafka-handler along with tests).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)