You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "zhangxinyao88 (via GitHub)" <gi...@apache.org> on 2026/08/26 04:03:13 UTC

[PR] Move default Celery tests to dedicated module [airflow]

zhangxinyao88 opened a new pull request, #72086:
URL: https://github.com/apache/airflow/pull/72086

   Move the existing tests for `airflow.providers.celery.executors.default_celery` out of the broader `test_celery_executor.py` module and into a dedicated test module that mirrors the source layout.
   
   This removes `test_default_celery.py` from `OVERLOOKED_TESTS` without changing production behavior.
   
   related: #35442
   
   Testing:
   
   - `breeze run pytest providers/celery/tests/unit/celery/executors/test_celery_executor.py providers/celery/tests/unit/celery/executors/test_default_celery.py -q`
   - `breeze run pytest airflow-core/tests/unit/always/test_project_structure.py::TestProjectStructure::test_providers_modules_should_have_tests -q`
   - `breeze testing providers-tests --parallel-test-types "Providers[celery] Providers[cncf.kubernetes] Providers[common.compat]" --run-in-parallel --parallelism 3`
   - Airflow pre-commit and manual hooks
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (Codex)
   
   Generated-by: Codex GPT-5 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move default Celery tests to dedicated module [airflow]

Posted by "zhangxinyao88 (via GitHub)" <gi...@apache.org>.
zhangxinyao88 commented on PR #72086:
URL: https://github.com/apache/airflow/pull/72086#issuecomment-5674738879

   > @zhangxinyao88 can you resolve conflicts here?
   
   Rebased onto current `main` and resolved the conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move default Celery tests to dedicated module [airflow]

Posted by "zhangxinyao88 (via GitHub)" <gi...@apache.org>.
zhangxinyao88 commented on PR #72086:
URL: https://github.com/apache/airflow/pull/72086#issuecomment-5487985848

   Hi @hussein-awala and @dheerajturaga, when you have a chance, could one of you take a look at this? It moves the existing default Celery tests into a dedicated module, and the focused and provider test suites pass locally. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move default Celery tests to dedicated module [airflow]

Posted by "zhangxinyao88 (via GitHub)" <gi...@apache.org>.
zhangxinyao88 commented on PR #72086:
URL: https://github.com/apache/airflow/pull/72086#issuecomment-5903517486

   @dheerajturaga @hussein-awala, I’ve updated this onto the latest `main`, and CI is green again. Could you take a look when you have a chance? Thanks!
   
   ---
   Drafted-by: Codex (GPT-5); reviewed by @zhangxinyao88 before posting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move default Celery tests to dedicated module [airflow]

Posted by "zhangxinyao88 (via GitHub)" <gi...@apache.org>.
zhangxinyao88 commented on PR #72086:
URL: https://github.com/apache/airflow/pull/72086#issuecomment-5578982459

   Done, thanks. I rebased and resolved the conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move default Celery tests to dedicated module [airflow]

Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #72086:
URL: https://github.com/apache/airflow/pull/72086#issuecomment-5572447387

   @zhangxinyao88 can you resolve conflicts here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org