[jira] Updated: (HADOOP-954) Metrics should offer complete set of static report methods or none at all

["David Bowen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Bowen updated HADOOP-954:
-------------------------------



The comments on this Metrics class say that it is a utility class (and the log name is org.apache.hadoop.util.MetricsUtil), but the name of the class implies that it is meant to be the main interface to the package.

I think that the comments at least should be changed to say that this class is intended to provide a simplified interface to a subset of the package's functionality.  It assumes that there is always exactly one tag in a record, defaulting to the hostname.

It also seems to assume that there is only one metric in a record, and that it is a gauge of type long.  This takes the simplified interface approach to a bit of an extreme.

My preference would be to move this class out of the metrics package and put it in dfs.  It doesn't make sense to have the apparent main interface to the metrics package omit most of its functionality.



> Metrics should offer complete set of static report methods or none at all
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-954
>                 URL: https://issues.apache.org/jira/browse/HADOOP-954
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.10.1
>            Reporter: Nigel Daley
>         Assigned To: David Bowen
>            Priority: Minor
>
> org.apache.hadoop.metrics.Metrics currently has one report method.  I should either have report methods for all underlying MetricsRecord or no report methods at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.