You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "SamWheating (via GitHub)" <gi...@apache.org> on 2023/09/20 20:21:29 UTC
[GitHub] [airflow] SamWheating opened a new pull request, #34509: Improve precision of the remove_task_decorator function
SamWheating opened a new pull request, #34509:
URL: https://github.com/apache/airflow/pull/34509
closes: https://github.com/apache/airflow/issues/34154
The `remove_task_decorator` can incorrectly truncate function bodies if there are specific comments in the function body present, which is a rare edge case but can lead to _really_ misleading behaviour where only a part of the intended code is executed.
I think that the correct way to do code manipulation like this would be to lean on the `ast` library, but the ability to go from ast back to code was only added in python 3.9 with the `ast.unparse()` function.
Anyways, this PR is an attempt to improve the accuracy of this method. While I don't think that this is perfect, it at least solves the issue for the cases in the linked issue. Any suggestions welcome.
If you want to discuss this IRL, come find me at Airflow Summit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve precision of the remove_task_decorator function [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34509:
URL: https://github.com/apache/airflow/pull/34509#issuecomment-1806951689
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve precision of the remove_task_decorator function [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34509: Improve precision of the remove_task_decorator function
URL: https://github.com/apache/airflow/pull/34509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org