You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/24 19:01:13 UTC
[GitHub] [ozone] HarshaR99 opened a new pull request, #3718: HDDS-6493 Improve TestOmKeyInfoCodec error handling
HarshaR99 opened a new pull request, #3718:
URL: https://github.com/apache/ozone/pull/3718
## What changes were proposed in this pull request?
The following usage in TestOmKeyInfoCodec isn't perfect. Can use some help.
} catch (IOException e) {
fail("Should success");
}
Suggest to let the exception to be thrown directly; remove the catch statement.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6493?jql=project%20%3D%20HDDS%20AND%20status%20%3D%20Open%20AND%20priority%20in%20(Low%2C%20Trivial)%20AND%20assignee%20in%20(EMPTY)%20ORDER%20BY%20created%20DESC
## How was this patch tested?
The existing test cases ran successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] HarshaR99 commented on pull request #3718: HDDS-6493. Improve TestOmKeyInfoCodec error handling.
Posted by GitBox <gi...@apache.org>.
HarshaR99 commented on PR #3718:
URL: https://github.com/apache/ozone/pull/3718#issuecomment-1227369089
Thanks @jojochuang, @ayushtkn and @adoroszlai for reviewing this patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3718: HDDS-6493. Improve TestOmKeyInfoCodec error handling.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3718:
URL: https://github.com/apache/ozone/pull/3718#issuecomment-1227110597
Thanks @HarshaR99 for the patch, @jojochuang for the review.
@HarshaR99 can you please let me know your Apache Jira username, so that the issue can be assigned to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3718: HDDS-6493. Improve TestOmKeyInfoCodec error handling.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3718:
URL: https://github.com/apache/ozone/pull/3718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] HarshaR99 commented on pull request #3718: HDDS-6493. Improve TestOmKeyInfoCodec error handling.
Posted by GitBox <gi...@apache.org>.
HarshaR99 commented on PR #3718:
URL: https://github.com/apache/ozone/pull/3718#issuecomment-1227367598
> > my apache username is harsha_r
>
> Thanks, added you as contributor, now you'll be able to assign other issues to yourself.
>
> I'll merge this later, currently we have a long queue of checks in Github.
Thanks @adoroszlai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] HarshaR99 commented on pull request #3718: HDDS-6493. Improve TestOmKeyInfoCodec error handling.
Posted by GitBox <gi...@apache.org>.
HarshaR99 commented on PR #3718:
URL: https://github.com/apache/ozone/pull/3718#issuecomment-1227222834
> Thanks @HarshaR99 for the patch, @jojochuang for the review.
>
> @HarshaR99 can you please let me know your Apache Jira username, so that the issue can be assigned to you?
Hi, @adoroszlai thanks for reviewing, my apache username is harsha_r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] HarshaR99 commented on pull request #3718: HDDS-6493 Improve TestOmKeyInfoCodec error handling
Posted by GitBox <gi...@apache.org>.
HarshaR99 commented on PR #3718:
URL: https://github.com/apache/ozone/pull/3718#issuecomment-1226129028
@jojochuang @adoroszlai Can you please review this patch, thanks !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3718: HDDS-6493. Improve TestOmKeyInfoCodec error handling.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3718:
URL: https://github.com/apache/ozone/pull/3718#issuecomment-1227245300
> my apache username is harsha_r
Thanks, added you as contributor, now you'll be able to assign other issues to yourself.
I'll merge this later, currently we have a long queue of checks in Github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org