You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by re...@apache.org on 2019/09/19 11:59:41 UTC

svn commit: r1867170 - /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/value/InternalValueFactory.java

Author: reschke
Date: Thu Sep 19 11:59:41 2019
New Revision: 1867170

URL: http://svn.apache.org/viewvc?rev=1867170&view=rev
Log:
JCR-4485: InternalValueFactory.create(File) does not close input stream

Modified:
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/value/InternalValueFactory.java

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/value/InternalValueFactory.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/value/InternalValueFactory.java?rev=1867170&r1=1867169&r2=1867170&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/value/InternalValueFactory.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/value/InternalValueFactory.java Thu Sep 19 11:59:41 2019
@@ -110,11 +110,8 @@ public final class InternalValueFactory
     }
 
     public QValue create(File value) throws RepositoryException, IOException {
-        InputStream in = new FileInputStream(value);
-        if (store == null) {
-            return InternalValue.createTemporary(in);
-        } else {
-            return InternalValue.create(in, store);
+        try (InputStream in = new FileInputStream(value)) {
+            return create(in);
         }
     }