[jira] [Commented] (FLINK-15156) Warn user if System.exit() is called in user code

["Thomas Braam (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178976#comment-17178976 ] 

Thomas Braam commented on FLINK-15156:
--------------------------------------

Hey all, first time contributor here, so please excuse me if I'm slow.

I've implemented the above mentioned SecurityManager in the [following commit|https://github.com/twbraam/flink/commit/fcc75c5f6270c5cc13538df81ee5539c86b52404]. However, in case of an exit(), this moves the current Task to FINISHED, while all the other Tasks stay in RUNNING status. I believe the intended behavior was to just log the fact that exit() was called and keep the Task running, so the above implementation is insufficient.

I guess I need to implement the above method on another level. I'll look some more into the code. In the meantime, if someone is willing to nudge me in the right direction, that would be appreciated.

> Warn user if System.exit() is called in user code
> -------------------------------------------------
>
>                 Key: FLINK-15156
>                 URL: https://issues.apache.org/jira/browse/FLINK-15156
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: Robert Metzger
>            Priority: Minor
>              Labels: starter
>
> It would make debugging Flink errors easier if we would intercept and log calls to System.exit() through the SecurityManager.
> A user recently had an error where the JobManager was shutting down because of a System.exit() in the user code: https://lists.apache.org/thread.html/b28dabcf3068d489f38399c456c80d48569fcdf74b15f8bb95d532d0%40%3Cuser.flink.apache.org%3E
> If I remember correctly, we had such issues before.
> I put this ticket into the "Runtime / Coordination" component, as it is mostly about improving the usability / debuggability in that area.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)