[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978#discussion_r659156947



##########
File path: arch/Kconfig
##########
@@ -259,9 +259,17 @@ config ARCH_NEED_ADDRENV_MAPPING
 	bool
 	default n
 
+config ARCH_HAVE_EXTRA_HEAPS
+	bool
+	default n
+	---help---
+		Special memory regions used as separate heaps
+
 config ARCH_HAVE_TEXT_HEAP
-	bool "Special memory region for dynamic code loading"
+	bool
 	default n

Review comment:
       This won't work well with SoCs that don't have an extra heap but just offset the buffer gotten from simple malloc.  Like [CXD56](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/cxd56xx/cxd56_textheap.c#L50-L80).  Part of what  I did here is to be able to remove that `up_textheap_init` function when it's not required.  (The term `textheap` could be a bit misleading here though).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org