You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@maven.org> on 2006/03/31 04:28:45 UTC
Using the embedder for ITs
Hi,
Just wanted to float the idea of using the embedder for the ITs. It's
been discussed before but now I think it's getting close to possible
with the work on the embedder-refactor branch. The CLI uses the embedder
on the branch and everything works.
The subtlety is that it will not be the command line anymore in the
strict sense even though it's the same code now. The one benefit is that
trying to run the ITs through the embedder I believe will stimulate some
cleanup in the core because I know for sure they would not all pass
right now because of some thread safety issues and use of System
properties. The other benefit is that the ITs would probably run in 5
seconds which would be nice.
Any thoughts?
--
jvz.
Jason van Zyl
jason at maven.org
http://maven.apache.org
We know what we are, but know not what we may be.
-- Shakespeare
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Using the embedder for ITs
Posted by Milos Kleint <mk...@gmail.com>.
On 4/3/06, Brett Porter <br...@apache.org> wrote:
> Jason van Zyl wrote:
> > After the 2.0.4 release I would like to merge what I have on the
> > embedder-refactor branch into the trunk.
>
> why wait? That's what trunk is for :D
+1
Milos
>
> - Brett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Using the embedder for ITs
Posted by Brett Porter <br...@apache.org>.
Jason van Zyl wrote:
> After the 2.0.4 release I would like to merge what I have on the
> embedder-refactor branch into the trunk.
why wait? That's what trunk is for :D
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Using the embedder for ITs
Posted by Jason van Zyl <ja...@maven.org>.
Brett Porter wrote:
> Another positive for this: it would enable us to use Continuum to run
> the integration tests on a particular version of Maven via the embedder,
> taking us one step closer to eliminating ci.sh.
Absolutely. It's archetype and embedder this week so I'll try to start
something there.
After the 2.0.4 release I would like to merge what I have on the
embedder-refactor branch into the trunk. So I'll post a little summary
of the changes therein. But all the tests are passing and Milos has
tried out the changes in the Netbeans plugin and Eugene has tried them
in the Eclipse plugin.
Another discussion might be tying in some of the common code Fabrizio is
talking about into the embedder and using it all from there. But that's
another email :-)
> - Brett
>
> Jason van Zyl wrote:
>> Hi,
>>
>> Just wanted to float the idea of using the embedder for the ITs. It's
>> been discussed before but now I think it's getting close to possible
>> with the work on the embedder-refactor branch. The CLI uses the embedder
>> on the branch and everything works.
>>
>> The subtlety is that it will not be the command line anymore in the
>> strict sense even though it's the same code now. The one benefit is that
>> trying to run the ITs through the embedder I believe will stimulate some
>> cleanup in the core because I know for sure they would not all pass
>> right now because of some thread safety issues and use of System
>> properties. The other benefit is that the ITs would probably run in 5
>> seconds which would be nice.
>>
>> Any thoughts?
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
--
jvz.
Jason van Zyl
jason at maven.org
http://maven.apache.org
First, the taking in of scattered particulars under one Idea,
so that everyone understands what is being talked about ... Second,
the separation of the Idea into parts, by dividing it at the joints,
as nature directs, not breaking any limb in half as a bad carver might.
-- Plato, Phaedrus (Notes on the Synthesis of Form by C. Alexander)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Using the embedder for ITs
Posted by Brett Porter <br...@apache.org>.
Another positive for this: it would enable us to use Continuum to run
the integration tests on a particular version of Maven via the embedder,
taking us one step closer to eliminating ci.sh.
- Brett
Jason van Zyl wrote:
> Hi,
>
> Just wanted to float the idea of using the embedder for the ITs. It's
> been discussed before but now I think it's getting close to possible
> with the work on the embedder-refactor branch. The CLI uses the embedder
> on the branch and everything works.
>
> The subtlety is that it will not be the command line anymore in the
> strict sense even though it's the same code now. The one benefit is that
> trying to run the ITs through the embedder I believe will stimulate some
> cleanup in the core because I know for sure they would not all pass
> right now because of some thread safety issues and use of System
> properties. The other benefit is that the ITs would probably run in 5
> seconds which would be nice.
>
> Any thoughts?
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Using the embedder for ITs
Posted by Brett Porter <br...@apache.org>.
Can we somehow add a mode to the embedder, or a wrapper around it, so
that forking an m2 instance instead is just configuration?
That way the default can be fast via the embedder, but the others
possible for release testing.
- Brett
Jason van Zyl wrote:
> Vincent Massol wrote:
>>
>>> -----Original Message-----
>>> From: Jason van Zyl [mailto:jason@maven.org]
>>> Sent: vendredi 31 mars 2006 04:29
>>> To: Maven Developers List
>>> Subject: Using the embedder for ITs
>>>
>>> Hi,
>>>
>>> Just wanted to float the idea of using the embedder for the ITs. It's
>>> been discussed before but now I think it's getting close to possible
>>> with the work on the embedder-refactor branch. The CLI uses the embedder
>>> on the branch and everything works.
>>>
>>> The subtlety is that it will not be the command line anymore in the
>>> strict sense even though it's the same code now. The one benefit is that
>>> trying to run the ITs through the embedder I believe will stimulate some
>>> cleanup in the core because I know for sure they would not all pass
>>> right now because of some thread safety issues and use of System
>>> properties. The other benefit is that the ITs would probably run in 5
>>> seconds which would be nice.
>>>
>>> Any thoughts?
>>
>> Jason, why would Its run faster with the embedded than they would do
>> through
>> maven proper?
>
> The JVM would be brought up once and the each IT would use the same
> instance of the embedder.
>
>> What is your suggestion here? Is it to modify the it plugin so that is
>> uses
>> the embedded. If so I think it makes complete sense and there's even a
>> comment already in the it plugin (AFAIR) saying that the code should be
>> replaced with the embedder...
>
> I'm thinking more the verifier code here. So instead of forking and
> invoking Maven each time for each IT an execution request would be made
> to the embedder. That should speed things up significantly. Just to be
> clear this would be for all the itXXX tests we have in maven-core-it.
>
> But the IT plugin would be another candidate for embedder use. So then
> the CLI, Ant Tasks, ITs and IDEs would use the same code.
>
>> Thanks
>> -Vincent
>>
>>
>>
>>
>>
>>
>> ___________________________________________________________________________
>> Nouveau : téléphonez moins cher avec Yahoo! Messenger ! Découvez les
>> tarifs exceptionnels pour appeler la France et l'international.
>> Téléchargez sur http://fr.messenger.yahoo.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Using the embedder for ITs
Posted by Jason van Zyl <ja...@maven.org>.
Vincent Massol wrote:
>
>> -----Original Message-----
>> From: Jason van Zyl [mailto:jason@maven.org]
>> Sent: vendredi 31 mars 2006 04:29
>> To: Maven Developers List
>> Subject: Using the embedder for ITs
>>
>> Hi,
>>
>> Just wanted to float the idea of using the embedder for the ITs. It's
>> been discussed before but now I think it's getting close to possible
>> with the work on the embedder-refactor branch. The CLI uses the embedder
>> on the branch and everything works.
>>
>> The subtlety is that it will not be the command line anymore in the
>> strict sense even though it's the same code now. The one benefit is that
>> trying to run the ITs through the embedder I believe will stimulate some
>> cleanup in the core because I know for sure they would not all pass
>> right now because of some thread safety issues and use of System
>> properties. The other benefit is that the ITs would probably run in 5
>> seconds which would be nice.
>>
>> Any thoughts?
>
> Jason, why would Its run faster with the embedded than they would do through
> maven proper?
The JVM would be brought up once and the each IT would use the same
instance of the embedder.
> What is your suggestion here? Is it to modify the it plugin so that is uses
> the embedded. If so I think it makes complete sense and there's even a
> comment already in the it plugin (AFAIR) saying that the code should be
> replaced with the embedder...
I'm thinking more the verifier code here. So instead of forking and
invoking Maven each time for each IT an execution request would be made
to the embedder. That should speed things up significantly. Just to be
clear this would be for all the itXXX tests we have in maven-core-it.
But the IT plugin would be another candidate for embedder use. So then
the CLI, Ant Tasks, ITs and IDEs would use the same code.
> Thanks
> -Vincent
>
>
>
>
>
>
> ___________________________________________________________________________
> Nouveau : téléphonez moins cher avec Yahoo! Messenger ! Découvez les tarifs exceptionnels pour appeler la France et l'international.
> Téléchargez sur http://fr.messenger.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
--
jvz.
Jason van Zyl
jason at maven.org
http://maven.apache.org
We all have problems. How we deal with them is a measure of our worth.
-- Unknown
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: Using the embedder for ITs
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Jason van Zyl [mailto:jason@maven.org]
> Sent: vendredi 31 mars 2006 04:29
> To: Maven Developers List
> Subject: Using the embedder for ITs
>
> Hi,
>
> Just wanted to float the idea of using the embedder for the ITs. It's
> been discussed before but now I think it's getting close to possible
> with the work on the embedder-refactor branch. The CLI uses the embedder
> on the branch and everything works.
>
> The subtlety is that it will not be the command line anymore in the
> strict sense even though it's the same code now. The one benefit is that
> trying to run the ITs through the embedder I believe will stimulate some
> cleanup in the core because I know for sure they would not all pass
> right now because of some thread safety issues and use of System
> properties. The other benefit is that the ITs would probably run in 5
> seconds which would be nice.
>
> Any thoughts?
Jason, why would Its run faster with the embedded than they would do through
maven proper?
What is your suggestion here? Is it to modify the it plugin so that is uses
the embedded. If so I think it makes complete sense and there's even a
comment already in the it plugin (AFAIR) saying that the code should be
replaced with the embedder...
Thanks
-Vincent
___________________________________________________________________________
Nouveau : t�l�phonez moins cher avec Yahoo! Messenger ! D�couvez les tarifs exceptionnels pour appeler la France et l'international.
T�l�chargez sur http://fr.messenger.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org