You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by co...@apache.org on 2013/03/06 18:32:59 UTC
svn commit: r1453445 - in
/cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j:
policyhandlers/AbstractBindingBuilder.java
policyvalidators/X509TokenPolicyValidator.java
Author: coheigea
Date: Wed Mar 6 17:32:59 2013
New Revision: 1453445
URL: http://svn.apache.org/r1453445
Log:
[CXF-4880] - Incorrect enforcement of X509Token PKI policies
Modified:
cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyhandlers/AbstractBindingBuilder.java
cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/X509TokenPolicyValidator.java
Modified: cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyhandlers/AbstractBindingBuilder.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyhandlers/AbstractBindingBuilder.java?rev=1453445&r1=1453444&r2=1453445&view=diff
==============================================================================
--- cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyhandlers/AbstractBindingBuilder.java (original)
+++ cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyhandlers/AbstractBindingBuilder.java Wed Mar 6 17:32:59 2013
@@ -427,7 +427,7 @@ public abstract class AbstractBindingBui
}
} else if (SPConstants.Layout.LaxTimestampFirst == layout.getValue()) {
if (timestamp == null) {
- ai.setNotAsserted(SPConstants.Layout.LaxTimestampLast + " requires a timestamp");
+ ai.setNotAsserted(SPConstants.Layout.LaxTimestampFirst + " requires a timestamp");
} else {
addTopDownElement(timestampEl.getElement());
}
Modified: cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/X509TokenPolicyValidator.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/X509TokenPolicyValidator.java?rev=1453445&r1=1453444&r2=1453445&view=diff
==============================================================================
--- cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/X509TokenPolicyValidator.java (original)
+++ cxf/trunk/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/X509TokenPolicyValidator.java Wed Mar 6 17:32:59 2013
@@ -94,8 +94,8 @@ public class X509TokenPolicyValidator ex
}
String requiredType = X509_V3_VALUETYPE;
- if (SPConstants.WSS_X509_PKI_PATH_V1_TOKEN10.equals(requiredType)
- || SPConstants.WSS_X509_PKI_PATH_V1_TOKEN11.equals(requiredType)) {
+ if (SPConstants.WSS_X509_PKI_PATH_V1_TOKEN10.equals(requiredVersionAndType)
+ || SPConstants.WSS_X509_PKI_PATH_V1_TOKEN11.equals(requiredVersionAndType)) {
requiredType = PKI_VALUETYPE;
}