You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/27 19:49:30 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #38754: [WIP][SPARK-41180][SQL] Reuse `INVALID_SCHEMA` instead of `_LEGACY_ERROR_TEMP_1227`
MaxGekk commented on code in PR #38754:
URL: https://github.com/apache/spark/pull/38754#discussion_r1033000254
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -780,8 +780,21 @@
},
"INVALID_SCHEMA" : {
"message" : [
- "The expression <expr> is not a valid schema string."
- ]
+ "The input schema <inputSchema> is not a valid schema string."
+ ],
+ "subClass" : {
+ "PARSE_ERROR" : {
+ "message" : [
+ "Cannot parse the schema: ",
+ "<reason>"
+ ]
+ },
+ "UNEXPECTED_INPUT_TYPE" : {
Review Comment:
How about `NON_STRING_LITERAL`?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -780,8 +780,21 @@
},
"INVALID_SCHEMA" : {
"message" : [
- "The expression <expr> is not a valid schema string."
- ]
+ "The input schema <inputSchema> is not a valid schema string."
+ ],
+ "subClass" : {
+ "PARSE_ERROR" : {
+ "message" : [
+ "Cannot parse the schema: ",
Review Comment:
```suggestion
"Cannot parse the schema:",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org