You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/10 16:58:06 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26315: Convert airflow/serialization to __future__.annotations
potiuk opened a new pull request, #26315:
URL: https://github.com/apache/airflow/pull/26315
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968300318
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26315:
URL: https://github.com/apache/airflow/pull/26315#issuecomment-1245282006
Closing as this one will be merged as part of #26289 #26290. See https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp for details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968297584
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968170228
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
This file is otherwise empty, and so I think it should not have this import and stay that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968257354
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
Yeah. I will check for those - I only skipped these __init__.py files that were literally "licence comment only" - those that have docstring were not seen as "empty" :)
But it will be easy to filter out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #26315: Convert airflow/serialization to __future__.annotations
URL: https://github.com/apache/airflow/pull/26315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968263093
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
This is an otherwise empty file -- we shouldn't add the import here I don't think? (Doesn't matter I guess)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968266098
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
This is the only one I've seen so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26315: Convert airflow/serialization to __future__.annotations
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26315:
URL: https://github.com/apache/airflow/pull/26315#discussion_r968263093
##########
airflow/serialization/__init__.py:
##########
@@ -15,5 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
"""DAG serialization."""
+from __future__ import annotations
Review Comment:
This is an otherwise empty file -- we shouldn't add the import here I don't think? (Doesn't matter I guess)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org