You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Vladimir Sitnikov (JIRA)" <ji...@apache.org> on 2019/02/27 07:33:00 UTC
[jira] [Resolved] (CALCITE-2878) Avoid use of new
RuntimeException(e) in tests
[ https://issues.apache.org/jira/browse/CALCITE-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Sitnikov resolved CALCITE-2878.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.19.0
Fixed in https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=ebafff1ede5921901b322872693bf1dbdf09fc8d
> Avoid use of new RuntimeException(e) in tests
> ---------------------------------------------
>
> Key: CALCITE-2878
> URL: https://issues.apache.org/jira/browse/CALCITE-2878
> Project: Calcite
> Issue Type: Bug
> Reporter: Vladimir Sitnikov
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{new RuntimeException(e)}} adds very little info in tests, and it makes stacktraces harder to read.
> So it makes sense to just sneaky-throw in those cases, especially for test purposes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)