You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/10/28 22:38:35 UTC

[GitHub] [openwhisk] rabbah commented on a change in pull request #4699: Optimize ack messages for setups not collecting logs

rabbah commented on a change in pull request #4699: Optimize ack messages for setups not collecting logs 
URL: https://github.com/apache/openwhisk/pull/4699#discussion_r339824080
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala
 ##########
 @@ -631,23 +630,27 @@ class ContainerProxy(
             ActivationResponse.whiskError(Messages.abnormalRun))
       }
 
+    val logsToBeCollected = collectLogs.logsToBeCollected(job.action)
+    val sendCompletionAfterLogsCollection = logsToBeCollected == true
 
 Review comment:
   instead of defining these two values which are essentially the same (value), how about just defining one value with this name and using it accordingly `splitAckMessagesPendingLogCollection`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services