You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2018/08/07 22:57:00 UTC
[jira] [Commented] (LUCENE-8343) BlendedInfixSuggester bad score
calculus for certain suggestion weights
[ https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572459#comment-16572459 ]
Michael McCandless commented on LUCENE-8343:
--------------------------------------------
Thanks [~alessandro.benedetti] – the latest patch looks good to me, and passes {{and precommit}} and Lucene tests, but I'm hitting a few Solr failures:
{noformat}
[junit4] Tests with failures [seed: 49604CF03EE2D834]:
[junit4] - org.apache.solr.client.solrj.response.TestSuggesterResponse.testSuggesterResponseObject
[junit4] - org.apache.solr.client.solrj.response.TestSuggesterResponse.testEmptySuggesterResponse
[junit4] - org.apache.solr.client.solrj.response.TestSuggesterResponse.testSuggesterResponseTerms{noformat}
This seems to be the root cause:
{noformat}
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestSuggesterResponse -Dtests.method=testSuggesterResponseObject -Dtests.seed=49604CF\
03EE2D834 -Dtests.badapples=true -Dtests.locale=is-IS -Dtests.timezone=Africa/Tunis -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
[junit4] ERROR 0.03s J2 | TestSuggesterResponse.testSuggesterResponseObject <<<
[junit4] > Throwable #1: org.apache.solr.client.solrj.SolrServerException: org.apache.solr.client.solrj.SolrServerException: java.lang.Null\
PointerException
[junit4] > at __randomizedtesting.SeedInfo.seed([49604CF03EE2D834:9C197DBE8EBE03B0]:0)
[junit4] > at org.apache.solr.client.solrj.embedded.EmbeddedSolrServer.request(EmbeddedSolrServer.java:233)
[junit4] > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:194)
[junit4] > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:211)
[junit4] > at org.apache.solr.client.solrj.response.TestSuggesterResponse.testSuggesterResponseObject(TestSuggesterResponse.java:54)
[junit4] > at java.lang.Thread.run(Thread.java:745)
[junit4] > Caused by: org.apache.solr.client.solrj.SolrServerException: java.lang.NullPointerException
[junit4] > at org.apache.solr.client.solrj.embedded.EmbeddedSolrServer.checkForExceptions(EmbeddedSolrServer.java:301)
[junit4] > at org.apache.solr.client.solrj.embedded.EmbeddedSolrServer.request(EmbeddedSolrServer.java:192)
[junit4] > ... 42 more
[junit4] > Caused by: java.lang.NullPointerException
[junit4] > at org.apache.lucene.search.suggest.analyzing.AnalyzingSuggester.build(AnalyzingSuggester.java:466)
[junit4] > at org.apache.lucene.search.suggest.Lookup.build(Lookup.java:194)
[junit4] > at org.apache.solr.spelling.suggest.SolrSuggester.build(SolrSuggester.java:181)
[junit4] > at org.apache.solr.handler.component.SuggestComponent.prepare(SuggestComponent.java:185)
[junit4] > at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:272)
[junit4] > at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:199)
[junit4] > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2541)
[junit4] > at org.apache.solr.client.solrj.embedded.EmbeddedSolrServer.request(EmbeddedSolrServer.java:191){noformat}
> BlendedInfixSuggester bad score calculus for certain suggestion weights
> -----------------------------------------------------------------------
>
> Key: LUCENE-8343
> URL: https://issues.apache.org/jira/browse/LUCENE-8343
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Affects Versions: 7.3.1
> Reporter: Alessandro Benedetti
> Priority: Major
> Attachments: LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the BlendedInfixSuggester return a (long) score to rank the suggestions.
> This score is calculated as a multiplication between :
> long *Weight* : the suggestion weight, coming from a document field, it can be any long value ( including 1, 0,.. )
> double *Coefficient* : 0<=x<=1, calculated based on the position match, earlier the better
> The resulting score is a long, which means that at the moment, any weight<10 can bring inconsistencies.
> *Edge cases*
> Weight =1
> Score = 1( if we have a match at the beginning of the suggestion) or 0 ( for any other match)
> Weight =0
> Score = 0 ( independently of the position match coefficient)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org