[GitHub] [spark] yaooqinn commented on a change in pull request #26905: [SPARK-30266][SQL] Avoid match error and int overflow in ApproximatePercentile and Percentile

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #26905: [SPARK-30266][SQL] Avoid  match error and int overflow in ApproximatePercentile and Percentile
URL: https://github.com/apache/spark/pull/26905#discussion_r360769653
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
 ##########
 @@ -149,7 +149,7 @@ class ApproximatePercentileQuerySuite extends QueryTest with SharedSparkSession
     withTempView(table) {
       (1 to 1000).toDF("col").createOrReplaceTempView(table)
       checkAnswer(
-        spark.sql(s"SELECT percentile_approx(col, array(0.25 + 0.25D), 200 + 800D) FROM $table"),
+        spark.sql(s"SELECT percentile_approx(col, array(0.25 + 0.25D), 200 + 800) FROM $table"),
 
 Review comment:
   Yup, but do you mean disallowed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org