[GitHub] lucene-solr issue #49: SOLR-9279 Adds comparison function queries

[softwaredoug <gi...@git.apache.org>]

Github user softwaredoug commented on the issue:

    https://github.com/apache/lucene-solr/pull/49
  
    (note the last few commits based on your comments)
    
    On unifying somewhat with MultiBoolValues, or creating a BiBoolValues, I went down that path a bit David and it seems to complicate things. A couple of notes:
    
    - The bool values functions takes as input other boolfunctions, whereas the comparison value source takes in scalar values.  You can see this in how or, and, xor work: they loop over several boolean value sources and perform and, or, xor etc. We just need to pluck out two scalar values and compare them
    - The name `func` seems descriptive of this general behavior, whereas `compare` is more descriptive of the operation being perfomed by the comparison value source
    
    I think the comparison functions are more readable now as they are, but I'd be curious to get your thoughts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org