[GitHub] williaster commented on a change in pull request #5359: Upgrade to React==16.4.1 & Enzyme==3.3.0

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5359: Upgrade to React==16.4.1 &  Enzyme==3.3.0
URL: https://github.com/apache/incubator-superset/pull/5359#discussion_r216448964
 
 

 ##########
 File path: superset/assets/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx
 ##########
 @@ -3,7 +3,7 @@ import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
 import { describe, it } from 'mocha';
-import { shallow } from 'enzyme';
+import { mount, shallow } from 'enzyme';
 
 Review comment:
   do you really need `mount` or do you know why it is required now but not previously? It's good to avoid that when possible. wondering if calling `wrapper.update()` would fix (tho the docs say that applies to just mounted components)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org